feat(server,web): update email address (#1186)

* feat: change email

* test: change email

server/apps/immich/src/api-v1/user/dto/update-user.dto.ts

@@ -1,9 +1,13 @@
-import { IsNotEmpty, IsOptional } from 'class-validator';
+import { IsEmail, IsNotEmpty, IsOptional } from 'class-validator';
 
 export class UpdateUserDto {
   @IsNotEmpty()
   id!: string;
 
+  @IsEmail()
+  @IsOptional()
+  email?: string;
+
   @IsOptional()
   password?: string;
 

server/apps/immich/src/api-v1/user/user.core.ts

@@ -28,6 +28,13 @@ export class UserCore {
       throw new BadRequestException('Admin user exists');
     }
 
+    if (dto.email) {
+      const duplicate = await this.userRepository.getByEmail(dto.email);
+      if (duplicate && duplicate.id !== id) {
+        throw new BadRequestException('Email already in user by another account');
+      }
+    }
+
     try {
       if (dto.password) {
         dto.password = await hash(dto.password, SALT_ROUNDS);

server/apps/immich/src/api-v1/user/user.service.spec.ts

@@ -102,6 +102,28 @@ describe('UserService', () => {
       await expect(result).rejects.toBeInstanceOf(ForbiddenException);
     });
 
+    it('should let a user change their email', async () => {
+      const dto = { id: immichUser.id, email: 'updated@test.com' };
+
+      userRepositoryMock.get.mockResolvedValue(immichUser);
+      userRepositoryMock.update.mockResolvedValue(immichUser);
+
+      await sut.updateUser(immichUser, dto);
+
+      expect(userRepositoryMock.update).toHaveBeenCalledWith(immichUser.id, { email: 'updated@test.com' });
+    });
+
+    it('should not let a user change their email to one already in use', async () => {
+      const dto = { id: immichUser.id, email: 'updated@test.com' };
+
+      userRepositoryMock.get.mockResolvedValue(immichUser);
+      userRepositoryMock.getByEmail.mockResolvedValue(adminUser);
+
+      await expect(sut.updateUser(immichUser, dto)).rejects.toBeInstanceOf(BadRequestException);
+
+      expect(userRepositoryMock.update).not.toHaveBeenCalled();
+    });
+
     it('admin can update any user information', async () => {
       const update: UpdateUserDto = {
         id: immichUser.id,

server/immich-openapi-specs.json

@@ -2400,6 +2400,9 @@
           "id": {
             "type": "string"
           },
+          "email": {
+            "type": "string"
+          },
           "password": {
             "type": "string"
           },