feat(server): trash asset (#4015)

* refactor(server): delete assets endpoint

* fix: formatting

* chore: cleanup

* chore: open api

* chore(mobile): replace DeleteAssetDTO with BulkIdsDTOs

* feat: trash an asset

* chore(server): formatting

* chore: open api

* chore: wording

* chore: open-api

* feat(server): add withDeleted to getAssets queries

* WIP: mobile-recycle-bin

* feat(server): recycle-bin to system config

* feat(web): use recycle-bin system config

* chore(server): domain assetcore removed

* chore(server): rename recycle-bin to trash

* chore(web): rename recycle-bin to trash

* chore(server): always send soft deleted assets for getAllByUserId

* chore(web): formatting

* feat(server): permanent delete assets older than trashed period

* feat(web): trash empty placeholder image

* feat(server): empty trash

* feat(web): empty trash

* WIP: mobile-recycle-bin

* refactor(server): empty / restore trash to separate endpoint

* test(server): handle failures

* test(server): fix e2e server-info test

* test(server): deletion test refactor

* feat(mobile): use map settings from server-config to enable / disable map

* feat(mobile): trash asset

* fix(server): operations on assets in trash

* feat(web): show trash statistics

* fix(web): handle trash enabled

* fix(mobile): restore updates from trash

* fix(server): ignore trashed assets for person

* fix(server): add / remove search index when trashed / restored

* chore(web): format

* fix(server): asset service test

* fix(server): include trashed assts for duplicates from uploads

* feat(mobile): no dialog for trash, always dialog for permanent delete

* refactor(mobile): use isar where instead of dart filter

* refactor(mobile): asset provide - handle deletes in single db txn

* chore(mobile): review changes

* feat(web): confirmation before empty trash

* server: review changes

* fix(server): handle library changes

* fix: filter external assets from getting trashed / deleted

* fix(server): empty-bin

* feat: broadcast config update events through ws

* change order of trash button on mobile

* styling

* fix(mobile): do not show trashed toast for local only assets

---------

Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
Co-authored-by: Alex Tran <alex.tran1502@gmail.com>

server/test/e2e/server-info.e2e-spec.ts

@@ -92,6 +92,7 @@ describe(`${ServerInfoController.name} (e2e)`, () => {
         search: false,
         sidecar: true,
         tagImage: true,
+        trash: true,
       });
     });
   });
@@ -104,6 +105,7 @@ describe(`${ServerInfoController.name} (e2e)`, () => {
         loginPageMessage: '',
         oauthButtonText: 'Login with OAuth',
         mapTileUrl: 'https://tile.openstreetmap.org/{z}/{x}/{y}.png',
+        trashDays: 30,
       });
     });
   });

server/test/fixtures/asset.stub.ts

@@ -35,6 +35,7 @@ export const assetStub = {
     faces: [],
     sidecarPath: null,
     isReadOnly: false,
+    deletedAt: null,
     isOffline: false,
     isExternal: false,
     libraryId: 'library-id',
@@ -77,6 +78,7 @@ export const assetStub = {
     exifInfo: {
       fileSizeInByte: 123_000,
     } as ExifEntity,
+    deletedAt: null,
   }),
   noThumbhash: Object.freeze<AssetEntity>({
     id: 'asset-id',
@@ -112,6 +114,7 @@ export const assetStub = {
     originalFileName: 'asset-id.ext',
     faces: [],
     sidecarPath: null,
+    deletedAt: null,
   }),
   image: Object.freeze<AssetEntity>({
     id: 'asset-id',
@@ -146,6 +149,7 @@ export const assetStub = {
     sharedLinks: [],
     originalFileName: 'asset-id.jpg',
     faces: [],
+    deletedAt: null,
     sidecarPath: null,
     exifInfo: {
       fileSizeInByte: 5_000,
@@ -179,11 +183,12 @@ export const assetStub = {
     livePhotoVideoId: null,
     isOffline: false,
     libraryId: 'library-id',
-    library: libraryStub.uploadLibrary1,
+    library: libraryStub.externalLibrary1,
     tags: [],
     sharedLinks: [],
     originalFileName: 'asset-id.jpg',
     faces: [],
+    deletedAt: null,
     sidecarPath: null,
     exifInfo: {
       fileSizeInByte: 5_000,
@@ -226,6 +231,7 @@ export const assetStub = {
     exifInfo: {
       fileSizeInByte: 5_000,
     } as ExifEntity,
+    deletedAt: null,
   }),
   image1: Object.freeze<AssetEntity>({
     id: 'asset-id-1',
@@ -244,6 +250,7 @@ export const assetStub = {
     encodedVideoPath: null,
     createdAt: new Date('2023-02-23T05:06:29.716Z'),
     updatedAt: new Date('2023-02-23T05:06:29.716Z'),
+    deletedAt: null,
     localDateTime: new Date('2023-02-23T05:06:29.716Z'),
     isFavorite: true,
     isArchived: false,
@@ -302,6 +309,7 @@ export const assetStub = {
     exifInfo: {
       fileSizeInByte: 5_000,
     } as ExifEntity,
+    deletedAt: null,
   }),
   video: Object.freeze<AssetEntity>({
     id: 'asset-id',
@@ -340,6 +348,7 @@ export const assetStub = {
     exifInfo: {
       fileSizeInByte: 100_000,
     } as ExifEntity,
+    deletedAt: null,
   }),
   livePhotoMotionAsset: Object.freeze({
     id: 'live-photo-motion-asset',
@@ -411,6 +420,7 @@ export const assetStub = {
       longitude: 100,
       fileSizeInByte: 23_456,
     } as ExifEntity,
+    deletedAt: null,
   }),
   sidecar: Object.freeze<AssetEntity>({
     id: 'asset-id',
@@ -446,5 +456,12 @@ export const assetStub = {
     originalFileName: 'asset-id.ext',
     faces: [],
     sidecarPath: '/original/path.ext.xmp',
+    deletedAt: null,
+  }),
+  readOnly: Object.freeze({
+    id: 'read-only-asset',
+    isReadOnly: true,
+    libraryId: 'library-id',
+    library: libraryStub.uploadLibrary1,
   }),
 };

server/test/fixtures/shared-link.stub.ts

@@ -69,6 +69,7 @@ const assetResponse: AssetResponseDto = {
   tags: [],
   people: [],
   checksum: 'ZmlsZSBoYXNo',
+  isTrashed: false,
   libraryId: 'library-id',
 };
 
@@ -235,6 +236,7 @@ export const sharedLinkStub = {
           sharedLinks: [],
           faces: [],
           sidecarPath: null,
+          deletedAt: null,
         },
       ],
     },

server/test/repositories/asset.repository.mock.ts

@@ -9,6 +9,7 @@ export const newAssetRepositoryMock = (): jest.Mocked<IAssetRepository> => {
     getByIds: jest.fn().mockResolvedValue([]),
     getByAlbumId: jest.fn(),
     getByUserId: jest.fn(),
+    getById: jest.fn(),
     getWithout: jest.fn(),
     getByChecksum: jest.fn(),
     getWith: jest.fn(),
@@ -18,15 +19,16 @@ export const newAssetRepositoryMock = (): jest.Mocked<IAssetRepository> => {
     getAll: jest.fn().mockResolvedValue({ items: [], hasNextPage: false }),
     updateAll: jest.fn(),
     getByLibraryId: jest.fn(),
-    getById: jest.fn(),
     getByLibraryIdAndOriginalPath: jest.fn(),
     deleteAll: jest.fn(),
     save: jest.fn(),
+    remove: jest.fn(),
     findLivePhotoMatch: jest.fn(),
     getMapMarkers: jest.fn(),
     getStatistics: jest.fn(),
     getByTimeBucket: jest.fn(),
     getTimeBuckets: jest.fn(),
-    remove: jest.fn(),
+    restoreAll: jest.fn(),
+    softDeleteAll: jest.fn(),
   };
 };

server/test/repositories/communication.repository.mock.ts

@@ -3,5 +3,6 @@ import { ICommunicationRepository } from '@app/domain';
 export const newCommunicationRepositoryMock = (): jest.Mocked<ICommunicationRepository> => {
   return {
     send: jest.fn(),
+    broadcast: jest.fn(),
   };
 };