feat (server, web): Share with partner (#2388)

* feat(server, web): implement share with partner * chore: regenerate api * chore: regenerate api * Pass userId to getAssetCountByTimeBucket and getAssetByTimeBucket * chore: regenerate api * Use AssetGrid to view partner's assets * Remove disableNavBarActions flag * Check access to buckets * Apply suggestions from code review Co-authored-by: Jason Rasmussen <jrasm91@gmail.com> * Remove exception rethrowing * Simplify partner access check * Create new PartnerController * chore api:generate * Use partnerApi * Remove id from PartnerResponseDto * Refactor PartnerEntity * Rename args * Remove duplicate code in getAll * Create composite primary keys for partners table * Move asset access check into PartnerCore * Remove redundant getUserAssets call * Remove unused getUserAssets method * chore: regenerate api * Simplify getAll * Replace ?? with || * Simplify PartnerRepository.create * Introduce PartnerIds interface * Replace two database migrations with one * Simplify getAll * Change PartnerResponseDto to include UserResponseDto * Move partner sharing endpoints to PartnerController * Rename ShareController to SharedLinkController * chore: regenerate api after rebase * refactor: shared link remove return type * refactor: return user response dto * chore: regenerate open api * refactor: partner getAll * refactor: partner settings event typing * chore: remove unused code * refactor: add partners modal trigger * refactor: update url for viewing partner photos * feat: update partner sharing title * refactor: rename service method names * refactor: http exception logic to service, PartnerIds interface * chore: regenerate open api * test: coverage for domain code * fix: addPartner => createPartner * fix: missed rename * refactor: more code cleanup * chore: alphabetize settings order * feat: stop sharing confirmation modal * Enhance contrast of the email in dark mode * Replace button with CircleIconButton * Fix linter warning * Fix date types for PartnerEntity * Fix PartnerEntity creation * Reset assetStore state * Change layout of the partner's assets page * Add bulk download action for partner's assets --------- Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
2025-12-08 20:29:05 +00:00 · 2023-05-15 20:30:53 +03:00
parent 4524aa0d06
commit 7f2fa23179
55 changed files with 1669 additions and 92 deletions
--- a/server/libs/domain/src/partner/partner.service.spec.ts
+++ b/server/libs/domain/src/partner/partner.service.spec.ts
@@ -0,0 +1,102 @@
+import { BadRequestException } from '@nestjs/common';
+import { authStub, newPartnerRepositoryMock, partnerStub } from '../../test';
+import { PartnerDirection } from './partner.core';
+import { IPartnerRepository } from './partner.repository';
+import { PartnerService } from './partner.service';
+
+const responseDto = {
+  admin: {
+    createdAt: '2021-01-01',
+    deletedAt: undefined,
+    email: 'admin@test.com',
+    firstName: 'admin_first_name',
+    id: 'admin_id',
+    isAdmin: true,
+    lastName: 'admin_last_name',
+    oauthId: '',
+    profileImagePath: '',
+    shouldChangePassword: false,
+    updatedAt: '2021-01-01',
+  },
+  user1: {
+    createdAt: '2021-01-01',
+    deletedAt: undefined,
+    email: 'immich@test.com',
+    firstName: 'immich_first_name',
+    id: 'immich_id',
+    isAdmin: false,
+    lastName: 'immich_last_name',
+    oauthId: '',
+    profileImagePath: '',
+    shouldChangePassword: false,
+    updatedAt: '2021-01-01',
+  },
+};
+
+describe(PartnerService.name, () => {
+  let sut: PartnerService;
+  let partnerMock: jest.Mocked<IPartnerRepository>;
+
+  beforeEach(async () => {
+    partnerMock = newPartnerRepositoryMock();
+    sut = new PartnerService(partnerMock);
+  });
+
+  it('should work', () => {
+    expect(sut).toBeDefined();
+  });
+
+  describe('getAll', () => {
+    it("should return a list of partners with whom I've shared my library", async () => {
+      partnerMock.getAll.mockResolvedValue([partnerStub.adminToUser1, partnerStub.user1ToAdmin1]);
+      await expect(sut.getAll(authStub.user1, PartnerDirection.SharedBy)).resolves.toEqual([responseDto.admin]);
+      expect(partnerMock.getAll).toHaveBeenCalledWith(authStub.user1.id);
+    });
+
+    it('should return a list of partners who have shared their libraries with me', async () => {
+      partnerMock.getAll.mockResolvedValue([partnerStub.adminToUser1, partnerStub.user1ToAdmin1]);
+      await expect(sut.getAll(authStub.user1, PartnerDirection.SharedWith)).resolves.toEqual([responseDto.admin]);
+      expect(partnerMock.getAll).toHaveBeenCalledWith(authStub.user1.id);
+    });
+  });
+
+  describe('create', () => {
+    it('should create a new partner', async () => {
+      partnerMock.get.mockResolvedValue(null);
+      partnerMock.create.mockResolvedValue(partnerStub.adminToUser1);
+
+      await expect(sut.create(authStub.admin, authStub.user1.id)).resolves.toEqual(responseDto.user1);
+
+      expect(partnerMock.create).toHaveBeenCalledWith({
+        sharedById: authStub.admin.id,
+        sharedWithId: authStub.user1.id,
+      });
+    });
+
+    it('should throw an error when the partner already exists', async () => {
+      partnerMock.get.mockResolvedValue(partnerStub.adminToUser1);
+
+      await expect(sut.create(authStub.admin, authStub.user1.id)).rejects.toBeInstanceOf(BadRequestException);
+
+      expect(partnerMock.create).not.toHaveBeenCalled();
+    });
+  });
+
+  describe('remove', () => {
+    it('should remove a partner', async () => {
+      partnerMock.get.mockResolvedValue(partnerStub.adminToUser1);
+
+      await sut.remove(authStub.admin, authStub.user1.id);
+
+      expect(partnerMock.remove).toHaveBeenCalledWith(partnerStub.adminToUser1);
+    });
+
+    it('should throw an error when the partner does not exist', async () => {
+      partnerMock.get.mockResolvedValue(null);
+
+      await expect(sut.remove(authStub.admin, authStub.user1.id)).rejects.toBeInstanceOf(BadRequestException);
+
+      expect(partnerMock.remove).not.toHaveBeenCalled();
+    });
+  });
+});