KevinMidboe/immich
1
0
Fork 0
mirror of https://github.com/KevinMidboe/immich.git synced 2026-02-11 02:39:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(server): non-nullable IsOptional (#3939)

Browse Source 
* custom `IsOptional`

* added link to source

* formatting

* Update server/src/domain/domain.util.ts

Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

* nullable birth date endpoint

* made `nullable` a property

* formatting

* removed unused dto

* updated decorator arg

* fixed album e2e tests

* add null tests for auth e2e

* add null test for person e2e

* fixed tests

* added null test for user e2e

* removed unusued import

* log key in test name

* chore: add note about mobile not being able to use the endpoint

---------

Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
This commit is contained in:
Mert
2023-09-01 12:40:00 -04:00
committed by GitHub
parent ca35e5557b
commit 9539a361e4
43 changed files with 271 additions and 243 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
server/src/domain/album/dto/album-create.dto.ts
View File

@@ -1,6 +1,6 @@
import { ApiProperty } from '@nestjs/swagger';
import { IsNotEmpty, IsOptional, IsString } from 'class-validator';
import { ValidateUUID } from '../../domain.util';
import { IsNotEmpty, IsString } from 'class-validator';
import { Optional, ValidateUUID } from '../../domain.util';
export class CreateAlbumDto {
@IsNotEmpty()
@@ -9,7 +9,7 @@ export class CreateAlbumDto {
albumName!: string;
@IsString()
@IsOptional()
@Optional()
description?: string;
@ValidateUUID({ optional: true, each: true })

8
server/src/domain/album/dto/album-update.dto.ts
View File

@@ -1,12 +1,12 @@
import { IsOptional, IsString } from 'class-validator';
import { ValidateUUID } from '../../domain.util';
import { IsString } from 'class-validator';
import { ValidateUUID, Optional } from '../../domain.util';
export class UpdateAlbumDto {
@IsOptional()
@Optional()
@IsString()
albumName?: string;
@IsOptional()
@Optional()
@IsString()
description?: string;

6
server/src/domain/album/dto/album.dto.ts
View File

@@ -1,9 +1,9 @@
import { Transform } from 'class-transformer';
import { IsBoolean, IsOptional } from 'class-validator';
import { toBoolean } from '../../domain.util';
import { IsBoolean } from 'class-validator';
import { toBoolean, Optional } from '../../domain.util';
export class AlbumInfoDto {
@IsOptional()
@Optional()
@IsBoolean()
@Transform(toBoolean)
withoutAssets?: boolean;

6
server/src/domain/album/dto/get-albums.dto.ts
View File

@@ -1,10 +1,10 @@
import { ApiProperty } from '@nestjs/swagger';
import { Transform } from 'class-transformer';
import { IsBoolean, IsOptional } from 'class-validator';
import { toBoolean, ValidateUUID } from '../../domain.util';
import { IsBoolean } from 'class-validator';
import { toBoolean, ValidateUUID, Optional } from '../../domain.util';
export class GetAlbumsDto {
@IsOptional()
@Optional()
@IsBoolean()
@Transform(toBoolean)
@ApiProperty()