mirror of
				https://github.com/KevinMidboe/immich.git
				synced 2025-10-29 17:40:28 +00:00 
			
		
		
		
	feat(web, mobile): Options to show archived assets in map (#4293)
* Add include archive setting to map on web * open api * better naming for web isArchived variable * add withArchived setting to mobile * (e2e): tests for mapMarker endpoint and isArchived * isArchived to mobile * chore: cleanup test * chore: optimize e2e --------- Co-authored-by: shalong-tanwen <139912620+shalong-tanwen@users.noreply.github.com> Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
This commit is contained in:
		@@ -56,6 +56,7 @@ const createAsset = (
 | 
			
		||||
    deviceAssetId: `test_${id}`,
 | 
			
		||||
    deviceId: 'e2e-test',
 | 
			
		||||
    libraryId,
 | 
			
		||||
    isVisible: true,
 | 
			
		||||
    fileCreatedAt: createdAt,
 | 
			
		||||
    fileModifiedAt: new Date(),
 | 
			
		||||
    type: AssetType.IMAGE,
 | 
			
		||||
@@ -89,19 +90,25 @@ describe(`${AssetController.name} (e2e)`, () => {
 | 
			
		||||
    await api.authApi.adminSignUp(server);
 | 
			
		||||
    const admin = await api.authApi.adminLogin(server);
 | 
			
		||||
 | 
			
		||||
    const libraries = await api.libraryApi.getAll(server, admin.accessToken);
 | 
			
		||||
    const [libraries] = await Promise.all([
 | 
			
		||||
      api.libraryApi.getAll(server, admin.accessToken),
 | 
			
		||||
      api.userApi.create(server, admin.accessToken, user1Dto),
 | 
			
		||||
      api.userApi.create(server, admin.accessToken, user2Dto),
 | 
			
		||||
    ]);
 | 
			
		||||
 | 
			
		||||
    const defaultLibrary = libraries[0];
 | 
			
		||||
 | 
			
		||||
    await api.userApi.create(server, admin.accessToken, user1Dto);
 | 
			
		||||
    user1 = await api.authApi.login(server, { email: user1Dto.email, password: user1Dto.password });
 | 
			
		||||
    [user1, user2] = await Promise.all([
 | 
			
		||||
      api.authApi.login(server, { email: user1Dto.email, password: user1Dto.password }),
 | 
			
		||||
      api.authApi.login(server, { email: user2Dto.email, password: user2Dto.password }),
 | 
			
		||||
    ]);
 | 
			
		||||
 | 
			
		||||
    asset1 = await createAsset(assetRepository, user1, defaultLibrary.id, new Date('1970-01-01'));
 | 
			
		||||
    asset2 = await createAsset(assetRepository, user1, defaultLibrary.id, new Date('1970-01-02'));
 | 
			
		||||
    asset3 = await createAsset(assetRepository, user1, defaultLibrary.id, new Date('1970-02-01'));
 | 
			
		||||
 | 
			
		||||
    await api.userApi.create(server, admin.accessToken, user2Dto);
 | 
			
		||||
    user2 = await api.authApi.login(server, { email: user2Dto.email, password: user2Dto.password });
 | 
			
		||||
    asset4 = await createAsset(assetRepository, user2, defaultLibrary.id, new Date('1970-01-01'));
 | 
			
		||||
    [asset1, asset2, asset3, asset4] = await Promise.all([
 | 
			
		||||
      createAsset(assetRepository, user1, defaultLibrary.id, new Date('1970-01-01')),
 | 
			
		||||
      createAsset(assetRepository, user1, defaultLibrary.id, new Date('1970-01-02')),
 | 
			
		||||
      createAsset(assetRepository, user1, defaultLibrary.id, new Date('1970-02-01')),
 | 
			
		||||
      createAsset(assetRepository, user2, defaultLibrary.id, new Date('1970-01-01')),
 | 
			
		||||
    ]);
 | 
			
		||||
  });
 | 
			
		||||
 | 
			
		||||
  afterAll(async () => {
 | 
			
		||||
@@ -515,4 +522,45 @@ describe(`${AssetController.name} (e2e)`, () => {
 | 
			
		||||
      );
 | 
			
		||||
    });
 | 
			
		||||
  });
 | 
			
		||||
 | 
			
		||||
  describe('GET /asset/map-marker', () => {
 | 
			
		||||
    beforeEach(async () => {
 | 
			
		||||
      await assetRepository.save({ id: asset1.id, isArchived: true });
 | 
			
		||||
      await assetRepository.upsertExif({ assetId: asset1.id, latitude: 0, longitude: 0 });
 | 
			
		||||
      await assetRepository.upsertExif({ assetId: asset2.id, latitude: 0, longitude: 0 });
 | 
			
		||||
    });
 | 
			
		||||
 | 
			
		||||
    it('should require authentication', async () => {
 | 
			
		||||
      const { status, body } = await request(server).get('/asset/map-marker');
 | 
			
		||||
 | 
			
		||||
      expect(status).toBe(401);
 | 
			
		||||
      expect(body).toEqual(errorStub.unauthorized);
 | 
			
		||||
    });
 | 
			
		||||
 | 
			
		||||
    it('should get map markers for all non-archived assets', async () => {
 | 
			
		||||
      const { status, body } = await request(server)
 | 
			
		||||
        .get('/asset/map-marker')
 | 
			
		||||
        .set('Authorization', `Bearer ${user1.accessToken}`);
 | 
			
		||||
 | 
			
		||||
      expect(status).toBe(200);
 | 
			
		||||
      expect(body).toHaveLength(2);
 | 
			
		||||
      expect(body).toEqual(
 | 
			
		||||
        expect.arrayContaining([
 | 
			
		||||
          expect.objectContaining({ id: asset1.id }),
 | 
			
		||||
          expect.objectContaining({ id: asset2.id }),
 | 
			
		||||
        ]),
 | 
			
		||||
      );
 | 
			
		||||
    });
 | 
			
		||||
 | 
			
		||||
    it('should get all map markers', async () => {
 | 
			
		||||
      const { status, body } = await request(server)
 | 
			
		||||
        .get('/asset/map-marker')
 | 
			
		||||
        .set('Authorization', `Bearer ${user1.accessToken}`)
 | 
			
		||||
        .query({ isArchived: false });
 | 
			
		||||
 | 
			
		||||
      expect(status).toBe(200);
 | 
			
		||||
      expect(body).toHaveLength(1);
 | 
			
		||||
      expect(body).toEqual([expect.objectContaining({ id: asset2.id })]);
 | 
			
		||||
    });
 | 
			
		||||
  });
 | 
			
		||||
});
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user