From 33afa30c308f0841151a52ed0c7920311a5524ac Mon Sep 17 00:00:00 2001 From: Adam Roben Date: Mon, 22 Dec 2014 17:06:49 -0500 Subject: [PATCH] Don't use question marks in struct fields Apparently it doesn't work in Ruby 1.9. --- script/fast-submodule-update | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/script/fast-submodule-update b/script/fast-submodule-update index 01b8b3bd..dff1be7d 100755 --- a/script/fast-submodule-update +++ b/script/fast-submodule-update @@ -12,7 +12,7 @@ SLOW_SUBMODULES = %w[ vendor/grammars/ioke-outdated ] -class TaskResult < Struct.new(:submodule, :output, :success?); end +class TaskResult < Struct.new(:submodule, :output, :status); end def run_process(*args) read, write = IO.pipe @@ -21,12 +21,12 @@ def run_process(*args) output = read.read read.close Process.wait(pid) - [output, $?.success?] + [output, $?] end def update_submodule(submodule) - output, success = run_process("git", "submodule", "update", "--", submodule) - TaskResult.new(submodule, output, success) + output, status = run_process("git", "submodule", "update", "--", submodule) + TaskResult.new(submodule, output, status) end def run_thread(submodules, results) @@ -58,7 +58,7 @@ end success = true SUBMODULES.each do result = results.pop - unless result.success? + unless result.status.success? success = false puts "Error updating #{result.submodule}" end