feat: adds additional metrics for DHCP: last-seen, client-id, active-mac-address

This commit is contained in:
Leon Morten Richter
2024-03-24 11:41:53 +01:00
parent 0fe5417f48
commit 38cca12215
2 changed files with 14 additions and 17 deletions

View File

@@ -18,11 +18,11 @@ from mktxp.utils.utils import parse_mkt_uptime
class DHCPMetricsDataSource:
''' DHCP Metrics data provider
'''
'''
@staticmethod
def metric_records(router_entry, *, metric_labels = None, add_router_id = True, dhcp_cache = True, translate = True, bound = False):
if metric_labels is None or dhcp_cache:
metric_labels = ['host_name', 'comment', 'active_address', 'address', 'mac_address', 'server', 'expires_after']
metric_labels = ['host_name', 'comment', 'active_address', 'address', 'mac_address', 'server', 'expires_after', 'last_seen', 'client_id', 'active_mac_address']
if dhcp_cache and router_entry.dhcp_records:
return router_entry.dhcp_records
@@ -35,21 +35,19 @@ class DHCPMetricsDataSource:
# translation rules
translation_table = {}
if 'comment' in metric_labels:
translation_table['comment'] = lambda c: c if c else ''
translation_table['comment'] = lambda c: c if c else ''
if 'host_name' in metric_labels:
translation_table['host_name'] = lambda c: c if c else ''
translation_table['host_name'] = lambda c: c if c else ''
if 'expires_after' in metric_labels and translate:
translation_table['expires_after'] = lambda c: parse_mkt_uptime(c) if c else 0
translation_table['expires_after'] = lambda c: parse_mkt_uptime(c) if c else 0
if 'active_address' in metric_labels:
translation_table['active_address'] = lambda c: c if c else ''
translation_table['active_address'] = lambda c: c if c else ''
records = BaseDSProcessor.trimmed_records(router_entry, router_records = dhcp_lease_records, metric_labels = metric_labels, add_router_id = add_router_id, translation_table = translation_table)
if dhcp_cache:
router_entry.dhcp_records = records
return records
except Exception as exc:
print(f'Error getting dhcp info from router{router_entry.router_name}@{router_entry.config_entry.hostname}: {exc}')
return None