mirror of
				https://github.com/KevinMidboe/mktxp-no-cli.git
				synced 2025-10-29 17:50:23 +00:00 
			
		
		
		
	kid control to monitor dynamic devices, optimisations/fixes
This commit is contained in:
		| @@ -25,18 +25,13 @@ class BGPCollector(BaseCollector): | ||||
|             return | ||||
|  | ||||
|         bgp_labels = ['name', 'remote_address', 'remote_as', 'local_as', 'remote_afi', 'local_afi', 'remote_messages', 'remote_bytes', 'local_messages', 'local_bytes', 'prefix_count', 'established', 'uptime'] | ||||
|         bgp_records = BGPMetricsDataSource.metric_records(router_entry, metric_labels=bgp_labels) | ||||
|         translation_table = { | ||||
|                 'established': lambda value: '1' if value=='true' else '0', | ||||
|                 'uptime': lambda value: BaseOutputProcessor.parse_timedelta_milliseconds(value) if value else '0' | ||||
|                 } | ||||
|         bgp_records = BGPMetricsDataSource.metric_records(router_entry, metric_labels=bgp_labels, translation_table = translation_table) | ||||
|          | ||||
|  | ||||
|         if bgp_records: | ||||
|             # translate records to appropriate values | ||||
|             translated_fields = ['established', 'uptime']         | ||||
|             for bgp_record in bgp_records: | ||||
|                 for translated_field in translated_fields: | ||||
|                     value = bgp_record.get(translated_field, None)     | ||||
|                     if value:             | ||||
|                         bgp_record[translated_field] = BGPCollector._translated_values(translated_field, value) | ||||
|  | ||||
|             session_info_labes = ['name', 'remote_address', 'remote_as', 'local_as', 'remote_afi', 'local_afi'] | ||||
|             bgp_sessions_metrics = BaseCollector.info_collector('bgp_sessions_info', 'BGP sessions info', bgp_records, session_info_labes) | ||||
|             yield bgp_sessions_metrics | ||||
| @@ -69,12 +64,3 @@ class BGPCollector(BaseCollector): | ||||
|             uptime_metrics = BaseCollector.gauge_collector('bgp_uptime', 'BGP uptime in milliseconds', bgp_records, 'uptime', session_id_labes) | ||||
|             yield uptime_metrics | ||||
|  | ||||
|  | ||||
|     # Helpers | ||||
|     @staticmethod | ||||
|     def _translated_values(translated_field, value): | ||||
|         return { | ||||
|                 'established': lambda value: '1' if value=='true' else '0', | ||||
|                 'uptime': lambda value: BaseOutputProcessor.parse_timedelta_milliseconds(value) | ||||
|                 }[translated_field](value) | ||||
|  | ||||
|   | ||||
| @@ -23,43 +23,29 @@ class KidDeviceCollector(BaseCollector): | ||||
|  | ||||
|     @staticmethod | ||||
|     def collect(router_entry): | ||||
|         if not router_entry.config_entry.kid_control_devices: | ||||
|         if not (router_entry.config_entry.kid_control_assigned or router_entry.config_entry.kid_control_dynamic): | ||||
|             return | ||||
|  | ||||
|         labels = ['name', 'user', 'mac_address', 'ip_address', 'bytes_down', 'bytes_up', 'rate_up', 'rate_down', | ||||
|                   'bytes_up', 'idle_time', | ||||
|                   'blocked', 'limited', 'inactive', 'disabled'] | ||||
|         info_labels = ['name', 'user', 'mac_address', 'ip_address', 'disabled'] | ||||
|         records = KidDeviceMetricsDataSource.metric_records(router_entry, metric_labels=labels) | ||||
|         labels = ['name', 'user', 'mac_address', 'ip_address', 'bytes_down', 'bytes_up', 'rate_up',  | ||||
|                     'rate_down','bytes_up', 'idle_time','blocked', 'limited', 'inactive', 'disabled'] | ||||
|  | ||||
|         translation_table = { | ||||
|             'rate_up': lambda value: BaseOutputProcessor.parse_rates(value), | ||||
|             'rate_down': lambda value: BaseOutputProcessor.parse_rates(value), | ||||
|             'idle_time': lambda value: BaseOutputProcessor.parse_timedelta_seconds(value) if value else 0, | ||||
|             'blocked': lambda value: '1' if value == 'true' else '0', | ||||
|             'limited': lambda value: '1' if value == 'true' else '0', | ||||
|             'inactive': lambda value: '1' if value == 'true' else '0', | ||||
|             'disabled': lambda value: '1' if value == 'true' else '0'} | ||||
|  | ||||
|         records = KidDeviceMetricsDataSource.metric_records(router_entry, metric_labels=labels, translation_table=translation_table) | ||||
|         if records: | ||||
|             # translate records to appropriate values | ||||
|             for record in records: | ||||
|                 for label in record: | ||||
|                     value = record.get(label, None) | ||||
|                     if value: | ||||
|                         record[label] = KidDeviceCollector._translated_values(label, value) | ||||
|  | ||||
|             info_labels = ['name', 'user', 'mac_address', 'ip_address', 'disabled'] | ||||
|             yield BaseCollector.info_collector('kid_control_device', 'Kid-control device Info', records, info_labels) | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_bytes_down', 'Number of received bytes', records, 'bytes_down', ['name', 'mac_address', 'user']) | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_bytes_up', 'Number of transmitted bytes', records, 'bytes_up', ['name', 'mac_address', 'user']) | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_rate_down', 'Device rate down', records, 'rate_down', ['name', 'mac_address', 'user']) | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_rate_up', 'Device rate up', records, 'rate_up', ['name', 'mac_address', 'user']) | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_idle_time', 'Device idle time', records, 'idle_time', ['name', 'mac_address', 'user']) | ||||
|  | ||||
|     # Helpers | ||||
|     @staticmethod | ||||
|     def _translated_values(monitor_label, value): | ||||
|         try: | ||||
|             return { | ||||
|                 'rate_up': lambda value: BaseOutputProcessor.parse_rates(value), | ||||
|                 'rate_down': lambda value: BaseOutputProcessor.parse_rates(value), | ||||
|                 'idle_time': lambda value: BaseOutputProcessor.parse_timedelta_seconds(value), | ||||
|                 'blocked': lambda value: '1' if value == 'true' else '0', | ||||
|                 'limited': lambda value: '1' if value == 'true' else '0', | ||||
|                 'inactive': lambda value: '1' if value == 'true' else '0', | ||||
|                 'disabled': lambda value: '1' if value == 'true' else '0', | ||||
|             }[monitor_label](value) | ||||
|         except KeyError: | ||||
|             # default to just returning the value | ||||
|             return value | ||||
|             id_labels = ['name', 'mac_address', 'user'] | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_bytes_down', 'Number of received bytes', records, 'bytes_down', id_labels) | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_bytes_up', 'Number of transmitted bytes', records, 'bytes_up', id_labels) | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_rate_down', 'Device rate down', records, 'rate_down', id_labels) | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_rate_up', 'Device rate up', records, 'rate_up', id_labels) | ||||
|             yield BaseCollector.gauge_collector('kid_control_device_idle_time', 'Device idle time', records, 'idle_time', id_labels) | ||||
|   | ||||
| @@ -26,15 +26,16 @@ class MonitorCollector(BaseCollector): | ||||
|             return | ||||
|  | ||||
|         monitor_labels = ['status', 'rate', 'full_duplex', 'name', 'sfp_temperature'] | ||||
|         monitor_records = InterfaceMonitorMetricsDataSource.metric_records(router_entry, metric_labels = monitor_labels, include_comments = True)    | ||||
|         translation_table = { | ||||
|                 'status': lambda value: '1' if value=='link-ok' else '0', | ||||
|                 'rate': lambda value: MonitorCollector._rates(value) if value else '0', | ||||
|                 'full_duplex': lambda value: '1' if value=='true' else '0', | ||||
|                 'name': lambda value: value if value else '', | ||||
|                 'sfp_temperature': lambda value: value if value else '0' | ||||
|                 } | ||||
|         monitor_records = InterfaceMonitorMetricsDataSource.metric_records(router_entry, metric_labels = monitor_labels,  | ||||
|                                                                                         translation_table=translation_table, include_comments = True)    | ||||
|         if monitor_records: | ||||
|             # translate records to appropriate values | ||||
|             for monitor_record in monitor_records: | ||||
|                 for monitor_label in monitor_labels: | ||||
|                     value = monitor_record.get(monitor_label, None)     | ||||
|                     if value:             | ||||
|                         monitor_record[monitor_label] = MonitorCollector._translated_values(monitor_label, value) | ||||
|  | ||||
|             monitor_status_metrics = BaseCollector.gauge_collector('interface_status', 'Current interface link status', monitor_records, 'status', ['name']) | ||||
|             yield monitor_status_metrics | ||||
|  | ||||
| @@ -50,17 +51,6 @@ class MonitorCollector(BaseCollector): | ||||
|             sfp_temperature_metrics = BaseCollector.gauge_collector('interface_sfp_temperature', 'Current SFP temperature', monitor_records, 'sfp_temperature', ['name']) | ||||
|             yield sfp_temperature_metrics | ||||
|  | ||||
|     # Helpers | ||||
|     @staticmethod | ||||
|     def _translated_values(monitor_label, value): | ||||
|         return { | ||||
|                 'status': lambda value: '1' if value=='link-ok' else '0', | ||||
|                 'rate': lambda value: MonitorCollector._rates(value), | ||||
|                 'full_duplex': lambda value: '1' if value=='true' else '0', | ||||
|                 'name': lambda value: value, | ||||
|                 'sfp_temperature': lambda value: value | ||||
|                 }[monitor_label](value) | ||||
|  | ||||
|     @staticmethod | ||||
|     def _rates(rate_option): | ||||
|         # according mikrotik docs, an interface rate should be one of these | ||||
|   | ||||
| @@ -27,17 +27,10 @@ class SystemResourceCollector(BaseCollector): | ||||
|                            'cpu', 'cpu_count', 'cpu_frequency', 'cpu_load',  | ||||
|                            'free_hdd_space', 'total_hdd_space',  | ||||
|                            'architecture_name', 'board_name'] | ||||
|                                     | ||||
|         resource_records = SystemResourceMetricsDataSource.metric_records(router_entry, metric_labels = resource_labels)    | ||||
|         if resource_records: | ||||
|             # translate records to appropriate values | ||||
|             translated_fields = ['uptime']         | ||||
|             for resource_record in resource_records: | ||||
|                 for translated_field in translated_fields: | ||||
|                     value = resource_record.get(translated_field, None)     | ||||
|                     if value:             | ||||
|                         resource_record[translated_field] = SystemResourceCollector._translated_values(translated_field, value) | ||||
|         translation_table = {'uptime': lambda value: BaseOutputProcessor.parse_timedelta_seconds(value)} | ||||
|  | ||||
|         resource_records = SystemResourceMetricsDataSource.metric_records(router_entry, metric_labels = resource_labels, translation_table=translation_table)    | ||||
|         if resource_records: | ||||
|             uptime_metrics = BaseCollector.gauge_collector('system_uptime', 'Time interval since boot-up', resource_records, 'uptime', ['version', 'board_name', 'cpu', 'architecture_name']) | ||||
|             yield uptime_metrics | ||||
|  | ||||
| @@ -71,12 +64,3 @@ class SystemResourceCollector(BaseCollector): | ||||
|  | ||||
|                 update_available_metrics = BaseCollector.gauge_collector('system_update_available', 'Is there a newer version available', resource_records, 'update_available', ['newest_version',]) | ||||
|                 yield update_available_metrics | ||||
|  | ||||
|  | ||||
|     # Helpers | ||||
|     @staticmethod | ||||
|     def _translated_values(translated_field, value): | ||||
|         return { | ||||
|                 'uptime': lambda value: BaseOutputProcessor.parse_timedelta_seconds(value) | ||||
|                 }[translated_field](value) | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user