KevinMidboe/mktxp-no-cli
1
0
Fork 0
mirror of https://github.com/KevinMidboe/mktxp-no-cli.git synced 2025-10-29 17:50:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

adapt health datasource to RouterOS v7

Browse Source
This commit is contained in:
Leon Morten Richter
2022-07-31 14:15:44 +02:00
parent 4962efd2a7
commit e1729105a9
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mktxp/datasource/health_ds.py
View File

@@ -22,6 +22,17 @@ class HealthMetricsDataSource:
def metric_records(router_entry, *, metric_labels = []): def metric_records(router_entry, *, metric_labels = []):
try: try:
health_records = router_entry.api_connection.router_api().get_resource('/system/health').get() health_records = router_entry.api_connection.router_api().get_resource('/system/health').get()
for record in health_records:
if 'name' in record:
# Note: The API in RouterOS v7.X+ returns a response like this:
# [{'name': 'temperature', 'value': '33', 'type': 'C'}, ...]
# To make this work for both v6 and v7 add a <name>:<value> pair in v7
# Otherwise it is not possible to get the value by name (e.g. records['voltage'])
name = record['name']
val = record.get('value', None)
record[name] = val
return BaseDSProcessor.trimmed_records(router_entry, router_records = health_records, metric_labels = metric_labels) return BaseDSProcessor.trimmed_records(router_entry, router_records = health_records, metric_labels = metric_labels)
except Exception as exc: except Exception as exc:
print(f'Error getting system health info from router{router_entry.router_name}@{router_entry.config_entry.hostname}: {exc}') print(f'Error getting system health info from router{router_entry.router_name}@{router_entry.config_entry.hostname}: {exc}')