Refactor and add blink method to all boards

This commit is contained in:
Ben Nuttall
2015-09-21 18:22:49 +01:00
parent be48a96e3e
commit 840953fd81

View File

@@ -11,16 +11,20 @@ class TrafficLights(object):
self.red = LED(red) self.red = LED(red)
self.amber = LED(amber) self.amber = LED(amber)
self.green = LED(green) self.green = LED(green)
self._lights = (self.red, self.amber, self.green) self._leds = (self.red, self.amber, self.green)
def on(self): def on(self):
for led in self._lights: for led in self._leds:
led.on() led.on()
def off(self): def off(self):
for led in self._lights: for led in self._leds:
led.off() led.off()
def blink(self, on_time=1, off_time=1):
for led in self._leds:
led.blink(on_time, off_time)
class PiTraffic(TrafficLights): class PiTraffic(TrafficLights):
def __init__(self): def __init__(self):
@@ -34,7 +38,7 @@ class FishDish(TrafficLights):
super(FishDish, self).__init__(red, amber, green) super(FishDish, self).__init__(red, amber, green)
self.buzzer = Buzzer(8) self.buzzer = Buzzer(8)
self.button = Button(pin=7, pull_up=False) self.button = Button(pin=7, pull_up=False)
self._all = tuple(list(self._lights) + [self.buzzer]) self._all = tuple(list(self._leds) + [self.buzzer])
def on(self): def on(self):
for thing in self._all: for thing in self._all:
@@ -53,13 +57,17 @@ class FishDish(TrafficLights):
class PiLiter(object): class PiLiter(object):
def __init__(self): def __init__(self):
leds = [4, 17, 27, 18, 22, 23, 24, 25] leds = (4, 17, 27, 18, 22, 23, 24, 25)
self.leds = tuple([LED(led) for led in leds]) self._leds = tuple([LED(led) for led in leds])
def on(self): def on(self):
for led in self.leds: for led in self._leds:
led.on() led.on()
def off(self): def off(self):
for led in self.leds: for led in self._leds:
led.off() led.off()
def blink(self, on_time=1, off_time=1):
for led in self._leds:
led.blink(on_time, off_time)