Add forward_device and backward_device to Motor, left_motor and
right_motor to Robot, and ensure all CompositeDevice descendents have a
proper close() method and closed property. Also, add a few more
_check_open calls around the place to make sure GPIODeviceClosed is
properly raised in response to read and writing values.
This commit is contained in:
Dave Jones
2015-11-15 17:05:31 +00:00
parent 382d6e45fc
commit c929b9a53b
3 changed files with 79 additions and 12 deletions

View File

@@ -62,7 +62,11 @@ class OutputDevice(SourceMixin, GPIODevice):
raise
def _write(self, value):
GPIO.output(self.pin, bool(value))
try:
GPIO.output(self.pin, bool(value))
except ValueError:
self._check_open()
raise
def on(self):
"""
@@ -236,12 +240,17 @@ class PWMOutputDevice(DigitalOutputDevice):
super(PWMOutputDevice, self).close()
def _read(self):
self._check_open()
return self._value
def _write(self, value):
if not 0 <= value <= 1:
raise OutputDeviceError("PWM value must be between 0 and 1")
self._pwm.ChangeDutyCycle(value * 100)
try:
self._pwm.ChangeDutyCycle(value * 100)
except AttributeError:
self._check_open()
raise
self._value = value
@property
@@ -385,6 +394,30 @@ class Motor(SourceMixin, CompositeDevice):
self._forward = PWMOutputDevice(forward)
self._backward = PWMOutputDevice(backward)
def close(self):
self._forward.close()
self._backward.close()
@property
def closed(self):
return self._forward.closed and self._backward.closed
@property
def forward_device(self):
"""
Returns the `PWMOutputDevice` representing the forward pin of the motor
controller.
"""
return self._forward
@property
def backward_device(self):
"""
Returns the `PWMOutputDevice` representing the backward pin of the
motor controller.
"""
return self._backward
@property
def value(self):
"""