KevinMidboe/seasoned
1
0
Fork 0
Code Issues 12 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Feat Refactor #72

Merged
KevinMidboe merged 130 commits from feat/refactor into master 2022-08-08 12:11:44 +00:00
Conversation 0 Commits 130 Files Changed 145 +10001 -8494
KevinMidboe commented 2022-03-06 11:09:04 +00:00 (Migrated from github.com)
Copy Link

Tried to simplify a lot of the functionality and logical separation of components.

Highlighted changes

View git history for full changelog by commit messages.

Bugs:

  • Fixes clicking outside popup not dismissing on mobile #8308a72
  • Load more button's intersection observer threshold increased to when button becomes in view, not entirely #be29242
Tried to simplify a lot of the functionality and logical separation of components. ## Highlighted changes View git history for full changelog by commit messages. - Updated webpack and all other packages to current version. - Define icons as vue components [#3b0039b](https://github.com/KevinMidboe/seasoned/pull/72/commits/3b0039b51b1bce3a16d3e63c51b92a645b0d0fed) - Separate person component [#b5c56a6](https://github.com/KevinMidboe/seasoned/pull/72/commits/b5c56a62de9302345b310f1745f8c813b82fc7d7) - Smarter movie description that only shows expand if more then 4 lines. - Cast and credits view on movie/show & person. - Opening movie/person popup updates query parameters - Code splitting - Started typescript conversion. - Authorization was handled multiple ways, now unified as cookie [#95ad74a](https://github.com/KevinMidboe/seasoned/pull/72/commits/95ad74a1b58b4a62da00964e173bf793b1c603ae) - Closes #11 - Closes #38 - Closes #42 - Closes #4 - Started #43 Bugs: - Fixes clicking outside popup not dismissing on mobile [#8308a72](https://github.com/KevinMidboe/seasoned/pull/72/commits/8308a7231a56a91b78c7f1fb40726d3b1fcebb1d) - Load more button's intersection observer threshold increased to when button becomes in view, not entirely [#be29242](https://github.com/KevinMidboe/seasoned/pull/72/commits/be29242cd3ea43d994d6950a5bf477358bd6f275)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
duplicate
This issue or pull request already exists
enhancement
New feature or request
feature request
good first issue
Good for newcomers
help wanted
Extra attention is needed
high
invalid
This doesn't seem right
low
medium
question
Further information is requested
registered users
ui
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KevinMidboe
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KevinMidboe/seasoned#72
No description provided.
Delete Branch "feat/refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?