Added more knowledge 🧠

This commit is contained in:
2018-10-18 22:14:08 +02:00
parent 3031353cc3
commit 028301c4c4

View File

@@ -567,4 +567,38 @@ sys 0m0.851s
``` ```
Keep nfo files? Keep nfo files?
# Program flow
videos -> scan_folder
scan_folder
videos
├ scan_video
├ search_external_subtitles
└ refine
ignored_videos -> None
error_paths -> not exists or directory but error while scan_videos
scan_folder-videos-scan_video =
raise error -> not exists or not VIDEO_EXT
video -> Video.fromguess
Video
-> fromguess
* Raise ValueError not episode or movie
Can I raise an error for everything that is not sufficient to move. Then return the errors with the videos. This catches the same number as video.sufficient, pickforgirlscouts.
Tweet argument for correction
How are the insufficient supposed to be handled?
* Return with videos to main and
Should not create dependencies in the code by have an exception doing something very specific to install and external data by checking if a guess can be resolved from checking earlier matches. I would be more nimble and modular approach to have our errors send back and returned and have a separate excution path which has the database element for checking eariler matches. Now the dependencies are segmented more in two different files, increasing upgradability.
Another note would be to not have rearly and error-prone calls happend deep in a execution path but have it separated so handling the errors for it can be high level and not have others functions error handling take over or missrepersent the original error.