Fix: Linter warnings (#137)

* Automaticly fixable eslint issues, mostly 3 -> 2 space indentation

* fix: updated plex_userid to camelcase

* Linted and some consistency refactor on middleware

* eslint uses ecmaversion 2020 & allow empty catch rule

* Started linting source files

* Fixed eslint errors & improved a lot of error handling

* Set 2 eslint rules as warning temporarly

src/notifications/sms.js

@@ -1,12 +1,21 @@
 const request = require("request");
 const configuration = require("../config/configuration").getInstance();
 
+class SMSUnexpectedError extends Error {
+  constructor(errorMessage) {
+    const message = "Unexpected error from sms provider.";
+    super(message);
+
+    this.errorMessage = errorMessage;
+  }
+}
+
 const sendSMS = message => {
   const apiKey = configuration.get("sms", "apikey");
 
   if (!apiKey) {
-    console.warning("api key for sms not set, cannot send sms.");
-    return null;
+    console.warning("api key for sms not set, cannot send sms."); // eslint-disable-line no-console
+    return Promise.resolve(null);
   }
 
   const sender = configuration.get("sms", "sender");
@@ -23,10 +32,9 @@ const sendSMS = message => {
           recipients: [{ msisdn: `47${recipient}` }]
         }
       },
-      function (err, r, body) {
-        console.log(err ? err : body);
-        console.log("sms provider response:", body);
-        resolve();
+      (err, r, body) => {
+        if (err) reject(new SMSUnexpectedError(err || body));
+        resolve(body);
       }
     );
   });