Fix: Linter warnings (#137)

* Automaticly fixable eslint issues, mostly 3 -> 2 space indentation

* fix: updated plex_userid to camelcase

* Linted and some consistency refactor on middleware

* eslint uses ecmaversion 2020 & allow empty catch rule

* Started linting source files

* Fixed eslint errors & improved a lot of error handling

* Set 2 eslint rules as warning temporarly

src/webserver/controllers/movie/info.js

@@ -1,22 +1,10 @@
 const configuration = require("../../../config/configuration").getInstance();
 const TMDB = require("../../../tmdb/tmdb");
 const Plex = require("../../../plex/plex");
+
 const tmdb = new TMDB(configuration.get("tmdb", "apiKey"));
 const plex = new Plex(configuration.get("plex", "ip"));
 
-function handleError(error, res) {
-  const { status, message } = error;
-
-  if (status && message) {
-    res.status(status).send({ success: false, message });
-  } else {
-    console.log("caught movieinfo controller error", error);
-    res.status(500).send({
-      message: "An unexpected error occured while requesting movie info"
-    });
-  }
-}
-
 /**
  * Controller: Retrieve information for a movie
  * @param {Request} req http request variable
@@ -25,21 +13,18 @@ function handleError(error, res) {
  */
 async function movieInfoController(req, res) {
   const movieId = req.params.id;
-  let { credits, release_dates, check_existance } = req.query;
 
-  credits && credits.toLowerCase() === "true"
-    ? (credits = true)
-    : (credits = false);
-  release_dates && release_dates.toLowerCase() === "true"
-    ? (release_dates = true)
-    : (release_dates = false);
-  check_existance && check_existance.toLowerCase() === "true"
-    ? (check_existance = true)
-    : (check_existance = false);
+  let credits = req.query?.credits;
+  let releaseDates = req.query?.release_dates;
+  let checkExistance = req.query?.check_existance;
 
-  let tmdbQueue = [tmdb.movieInfo(movieId)];
+  credits = credits?.toLowerCase() === "true";
+  releaseDates = releaseDates?.toLowerCase() === "true";
+  checkExistance = checkExistance?.toLowerCase() === "true";
+
+  const tmdbQueue = [tmdb.movieInfo(movieId)];
   if (credits) tmdbQueue.push(tmdb.movieCredits(movieId));
-  if (release_dates) tmdbQueue.push(tmdb.movieReleaseDates(movieId));
+  if (releaseDates) tmdbQueue.push(tmdb.movieReleaseDates(movieId));
 
   try {
     const [Movie, Credits, ReleaseDates] = await Promise.all(tmdbQueue);
@@ -47,24 +32,22 @@ async function movieInfoController(req, res) {
     const movie = Movie.createJsonResponse();
     if (Credits) movie.credits = Credits.createJsonResponse();
     if (ReleaseDates)
-      movie.release_dates = ReleaseDates.createJsonResponse().results;
+      movie.releaseDates = ReleaseDates.createJsonResponse().results;
 
-    if (check_existance) {
+    if (checkExistance) {
       try {
         movie.exists_in_plex = await plex.existsInPlex(movie);
-      } catch (error) {
-        if (error.status === 401) {
-          console.log("Unathorized request, check plex server LAN settings");
-        } else {
-          console.log("Unkown error from plex!");
-        }
-        console.log(error?.message);
-      }
+      } catch {}
     }
 
-    res.send(movie);
+    return res.send(movie);
   } catch (error) {
-    handleError(error, res);
+    return res.status(error?.statusCode || 500).send({
+      success: false,
+      message:
+        error?.message ||
+        `An unexpected error occured while requesting info for with id: ${movieId}`
+    });
   }
 }