KevinMidboe/seasonedShows
1
0
Fork 0
Code Issues 20 Pull Requests 2 Packages Projects Releases 8 Wiki Activity

Fix: Linter warnings (#137)

Browse Source 
* Automaticly fixable eslint issues, mostly 3 -> 2 space indentation

* fix: updated plex_userid to camelcase

* Linted and some consistency refactor on middleware

* eslint uses ecmaversion 2020 & allow empty catch rule

* Started linting source files

* Fixed eslint errors & improved a lot of error handling

* Set 2 eslint rules as warning temporarly
This commit was merged in pull request #137.
This commit is contained in:
Kevin
2022-08-20 17:21:25 +02:00
committed by GitHub
parent cfbd4965db
commit 1815a429b0
83 changed files with 1625 additions and 1294 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/webserver/controllers/show/info.js
View File

@@ -1,22 +1,10 @@
const configuration = require("../../../config/configuration").getInstance();
const TMDB = require("../../../tmdb/tmdb");
const Plex = require("../../../plex/plex");
const tmdb = new TMDB(configuration.get("tmdb", "apiKey"));
const plex = new Plex(configuration.get("plex", "ip"));
function handleError(error, res) {
const { status, message } = error;
if (status && message) {
res.status(status).send({ success: false, message });
} else {
console.log("caught showinfo controller error", error);
res.status(500).send({
message: "An unexpected error occured while requesting show info."
});
}
}
/**
* Controller: Retrieve information for a show
* @param {Request} req http request variable
@@ -26,16 +14,13 @@ function handleError(error, res) {
async function showInfoController(req, res) {
const showId = req.params.id;
let { credits, check_existance } = req.query;
let credits = req.query?.credits;
let checkExistance = req.query?.check_existance;
credits && credits.toLowerCase() === "true"
? (credits = true)
: (credits = false);
check_existance && check_existance.toLowerCase() === "true"
? (check_existance = true)
: (check_existance = false);
credits = credits?.toLowerCase() === "true";
checkExistance = checkExistance?.toLowerCase() === "true";
let tmdbQueue = [tmdb.showInfo(showId)];
const tmdbQueue = [tmdb.showInfo(showId)];
if (credits) tmdbQueue.push(tmdb.showCredits(showId));
try {
@@ -44,11 +29,21 @@ async function showInfoController(req, res) {
const show = Show.createJsonResponse();
if (credits) show.credits = Credits.createJsonResponse();
if (check_existance) show.exists_in_plex = await plex.existsInPlex(show);
if (checkExistance) {
/* eslint no-empty: ["error", { "allowEmptyCatch": true }] */
try {
show.exists_in_plex = await plex.existsInPlex(show);
} catch {}
}
res.send(show);
return res.send(show);
} catch (error) {
handleError(error, res);
return res.status(error?.statusCode || 500).send({
success: false,
message:
error?.message ||
`An unexpected error occured while requesting info for show with id: ${showId}`
});
}
}