Fix: Tests lint and src folder (#138)

* Automaticly fixable eslint issues, mostly 3 -> 2 space indentation

* fix: updated plex_userid to camelcase

* Linted and some consistency refactor on middleware

* eslint uses ecmaversion 2020 & allow empty catch rule

* Started linting source files

* Fixed eslint errors & improved a lot of error handling

* Set 2 eslint rules as warning temporarly

* Updated all import statements to be relative

* Updated mocha & nyc, resolved all lint issues in tests/

* Updated mocha & nyc. Removed production config. Updated gitignore

* Updated test commands to omit system tests, no exit code

* Updated test configuration w/ missing keys

* Chai modules defined in package.json & resolved linting errors

* Dockerfile copies development.example -> production.json. Simplified commands

* All api calls from tests use same chaiHttp implementation

Removes a list of fetch alternatives after being replaced by chaiHttp:
 - request
 - request-promise
 - supertest
 - supertest-as-promised

* Tests should use redis (mock) cache, not tmdb sqlite cache

* Disabled test asADeveloperIWantTheServerToStart

* Re-enable tests/system

* Use chaiHttp in asAUserIWantToRequestAMovie.

* Fixed redis expire & mock implmentation

* Replaced all fetch alternatives from source code and package.json

* Pass error from tmdb api back to client as errorMessage

* Updated authentication middleware to handle checks consitenctly

* Prevent assert error when checking request status, returns success 200

* Resolved merge conflicts

* Only build and publish docker container when branch master

package.json

@@ -7,54 +7,49 @@
   },
   "main": "webserver/server.js",
   "scripts": {
-    "start": "yarn cross-env SEASONED_CONFIG=configurations/production.json NODE_ENV=production babel-node src/webserver/server.js",
-    "dev": "yarn cross-env SEASONED_CONFIG=configurations/development.json NODE_ENV=development babel-node src/webserver/server.js",
-    "test": "cross-env SEASONED_CONFIG=configurations/test.json NODE_PATH=. mocha --require @babel/register --recursive tests/unit tests/system",
-    "coverage": "cross-env SEASONED_CONFIG=configurations/test.json NODE_PATH=. nyc mocha --require @babel/register --recursive test && nyc report --reporter=text-lcov | coveralls",
-    "lint": "eslint src",
-    "update": "cross-env SEASONED_CONFIG=configurations/development.json NODE_PATH=. node scripts/updateRequestsInPlex.js",
+    "start": "SEASONED_CONFIG=configurations/production.json NODE_ENV=production node src/webserver/server.js",
+    "dev": "SEASONED_CONFIG=configurations/development.json NODE_ENV=development node src/webserver/server.js",
+    "test": "SEASONED_CONFIG=configurations/test.json mocha --recursive tests/unit tests/system",
+    "coverage:upload": "SEASONED_CONFIG=configurations/test.json mocha --recursive tests/unit && nyc report --reporter=text-lcov | coveralls",
+    "coverage": "SEASONED_CONFIG=configurations/test.json mocha --recursive tests/unit && nyc report",
+    "lint": "eslint src tests",
+    "update": "SEASONED_CONFIG=configurations/development.json node scripts/updateRequestsInPlex.js",
     "docs": "yarn apiDocs; yarn classDocs",
     "apiDocs": "",
     "classDocs": "scripts/generate-class-docs.sh"
   },
   "dependencies": {
-    "axios": "^0.18.0",
     "bcrypt": "^5.0.1",
     "body-parser": "~1.18.2",
     "cookie-parser": "^1.4.6",
-    "cross-env": "~5.1.4",
     "express": "~4.16.0",
     "form-data": "^2.5.1",
     "jsonwebtoken": "^8.5.1",
     "km-moviedb": "^0.2.12",
-    "node-cache": "^4.1.1",
-    "node-fetch": "^2.6.0",
     "python-shell": "^0.5.0",
     "raven": "^2.4.2",
     "redis": "^3.0.2",
-    "request": "^2.87.0",
-    "request-promise": "^4.2",
     "sqlite3": "^5.0.1"
   },
   "devDependencies": {
     "@babel/core": "^7.5.5",
-    "@babel/node": "^7.5.5",
     "@babel/preset-env": "^7.5.5",
     "@babel/register": "^7.5.5",
     "@types/node": "^12.6.8",
+    "chai": "^4.3.6",
+    "chai-http": "^4.3.0",
     "coveralls": "^3.0.5",
     "documentation": "^12.0.3",
     "eslint": "^8.22.0",
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "^2.8.0",
+    "eslint-plugin-mocha": "10.1.0",
     "eslint-plugin-prettier": "^4.2.1",
     "istanbul": "^0.4.5",
-    "mocha": "^6.2.0",
+    "mocha": "8.4.0",
     "mocha-lcov-reporter": "^1.3.0",
-    "nyc": "^11.6.0",
-    "prettier": "^2.7.1",
-    "supertest": "^3.0.0",
-    "supertest-as-promised": "^4.0.1"
+    "nyc": "15.1.0",
+    "prettier": "^2.7.1"
   }
 }