Fix: Tests lint and src folder (#138)

* Automaticly fixable eslint issues, mostly 3 -> 2 space indentation

* fix: updated plex_userid to camelcase

* Linted and some consistency refactor on middleware

* eslint uses ecmaversion 2020 & allow empty catch rule

* Started linting source files

* Fixed eslint errors & improved a lot of error handling

* Set 2 eslint rules as warning temporarly

* Updated all import statements to be relative

* Updated mocha & nyc, resolved all lint issues in tests/

* Updated mocha & nyc. Removed production config. Updated gitignore

* Updated test commands to omit system tests, no exit code

* Updated test configuration w/ missing keys

* Chai modules defined in package.json & resolved linting errors

* Dockerfile copies development.example -> production.json. Simplified commands

* All api calls from tests use same chaiHttp implementation

Removes a list of fetch alternatives after being replaced by chaiHttp:
 - request
 - request-promise
 - supertest
 - supertest-as-promised

* Tests should use redis (mock) cache, not tmdb sqlite cache

* Disabled test asADeveloperIWantTheServerToStart

* Re-enable tests/system

* Use chaiHttp in asAUserIWantToRequestAMovie.

* Fixed redis expire & mock implmentation

* Replaced all fetch alternatives from source code and package.json

* Pass error from tmdb api back to client as errorMessage

* Updated authentication middleware to handle checks consitenctly

* Prevent assert error when checking request status, returns success 200

* Resolved merge conflicts

* Only build and publish docker container when branch master

src/notifications/sms.js

@@ -1,4 +1,3 @@
-const request = require("request");
 const configuration = require("../config/configuration").getInstance();
 
 class SMSUnexpectedError extends Error {
@@ -20,23 +19,21 @@ const sendSMS = message => {
 
   const sender = configuration.get("sms", "sender");
   const recipient = configuration.get("sms", "recipient");
+  const smsRequestHeaders = { "Content-Type": "application/json" };
+  const smsRequestBody = {
+    sender,
+    message,
+    recipients: [{ msisdn: `47${recipient}` }]
+  };
 
   return new Promise((resolve, reject) => {
-    request.post(
-      {
-        url: `https://gatewayapi.com/rest/mtsms?token=${apiKey}`,
-        json: true,
-        body: {
-          sender,
-          message,
-          recipients: [{ msisdn: `47${recipient}` }]
-        }
-      },
-      (err, r, body) => {
-        if (err) reject(new SMSUnexpectedError(err || body));
-        resolve(body);
-      }
-    );
+    fetch(`https://gatewayapi.com/rest/mtsms?token=${apiKey}`, {
+      body: JSON.stringify(smsRequestBody),
+      headers: smsRequestHeaders
+    })
+      .then(resp => resp.json())
+      .then(response => resolve(response))
+      .catch(error => reject(new SMSUnexpectedError(error)));
   });
 };