Fix: Tests lint and src folder (#138)

* Automaticly fixable eslint issues, mostly 3 -> 2 space indentation

* fix: updated plex_userid to camelcase

* Linted and some consistency refactor on middleware

* eslint uses ecmaversion 2020 & allow empty catch rule

* Started linting source files

* Fixed eslint errors & improved a lot of error handling

* Set 2 eslint rules as warning temporarly

* Updated all import statements to be relative

* Updated mocha & nyc, resolved all lint issues in tests/

* Updated mocha & nyc. Removed production config. Updated gitignore

* Updated test commands to omit system tests, no exit code

* Updated test configuration w/ missing keys

* Chai modules defined in package.json & resolved linting errors

* Dockerfile copies development.example -> production.json. Simplified commands

* All api calls from tests use same chaiHttp implementation

Removes a list of fetch alternatives after being replaced by chaiHttp:
 - request
 - request-promise
 - supertest
 - supertest-as-promised

* Tests should use redis (mock) cache, not tmdb sqlite cache

* Disabled test asADeveloperIWantTheServerToStart

* Re-enable tests/system

* Use chaiHttp in asAUserIWantToRequestAMovie.

* Fixed redis expire & mock implmentation

* Replaced all fetch alternatives from source code and package.json

* Pass error from tmdb api back to client as errorMessage

* Updated authentication middleware to handle checks consitenctly

* Prevent assert error when checking request status, returns success 200

* Resolved merge conflicts

* Only build and publish docker container when branch master

tests/system/asADeveloperIWantToLogin.js

@@ -1,27 +1,40 @@
-const assert = require('assert');
-const request = require('supertest-as-promised');
-const app = require('src/webserver/app');
-const createUser = require('test/helpers/createUser');
-const resetDatabase = require('test/helpers/resetDatabase');
+const assert = require("assert");
+const chai = require("chai");
+const chaiHttp = require("chai-http");
 
-describe('As a user I want to log in', () => {
-  before(() => {
-    return resetDatabase()
-    .then(() => createUser('test_user', 'password'))
-  })
+const server = require("../../src/webserver/server");
+const createUser = require("../helpers/createUser");
+const resetDatabase = require("../helpers/resetDatabase");
 
-  it('should return 200 with a token if correct credentials are given', () =>
-    request(app)
-    .post('/api/v1/user/login')
-    .send({ username: 'test_user', password: 'password' })
-    .expect(200)
-    .then(response => assert.equal(typeof response.body.token, 'string'))
-  );
+chai.use(chaiHttp);
 
-  it('should return 401 if incorrect credentials are given', () =>
-    request(app)
-    .post('/api/v1/user/login')
-    .send({ username: 'test_user', password: 'anti-password' })
-    .expect(401)
-  );
+describe("As a user I want to log in", () => {
+  beforeEach(() => resetDatabase());
+  beforeEach(() => createUser("test_user", "password"));
+
+  it("should return 200 with a token if correct credentials are given", done => {
+    chai
+      .request(server)
+      .post("/api/v1/user/login")
+      .send({ username: "test_user", password: "password" })
+      .end((error, response) => {
+        // console.log(response);
+
+        assert.equal(response?.status, 200);
+        done();
+      });
+  });
+
+  it("should return 401 if incorrect credentials are given", done => {
+    chai
+      .request(server)
+      .post("/api/v1/user/login")
+      .send({ username: "test_user", password: "anti-password" })
+      .end((error, response) => {
+        // console.log(response);
+
+        assert.equal(response?.status, 401);
+        done();
+      });
+  });
 });