KevinMidboe/seasonedShows
1
0
Fork 0
Code Issues 20 Pull Requests 2 Packages Projects Releases 8 Wiki Activity

Fix: Tests lint and src folder (#138)

Browse Source 
* Automaticly fixable eslint issues, mostly 3 -> 2 space indentation

* fix: updated plex_userid to camelcase

* Linted and some consistency refactor on middleware

* eslint uses ecmaversion 2020 & allow empty catch rule

* Started linting source files

* Fixed eslint errors & improved a lot of error handling

* Set 2 eslint rules as warning temporarly

* Updated all import statements to be relative

* Updated mocha & nyc, resolved all lint issues in tests/

* Updated mocha & nyc. Removed production config. Updated gitignore

* Updated test commands to omit system tests, no exit code

* Updated test configuration w/ missing keys

* Chai modules defined in package.json & resolved linting errors

* Dockerfile copies development.example -> production.json. Simplified commands

* All api calls from tests use same chaiHttp implementation

Removes a list of fetch alternatives after being replaced by chaiHttp:
 - request
 - request-promise
 - supertest
 - supertest-as-promised

* Tests should use redis (mock) cache, not tmdb sqlite cache

* Disabled test asADeveloperIWantTheServerToStart

* Re-enable tests/system

* Use chaiHttp in asAUserIWantToRequestAMovie.

* Fixed redis expire & mock implmentation

* Replaced all fetch alternatives from source code and package.json

* Pass error from tmdb api back to client as errorMessage

* Updated authentication middleware to handle checks consitenctly

* Prevent assert error when checking request status, returns success 200

* Resolved merge conflicts

* Only build and publish docker container when branch master
This commit was merged in pull request #138.
This commit is contained in:
Kevin
2022-08-20 17:41:46 +02:00
committed by GitHub
parent 1815a429b0
commit 628ed52012
44 changed files with 1248 additions and 1592 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
tests/system/asAUserIWantToRequestAMovie.js
View File

@@ -1,23 +1,29 @@
const resetDatabase = require('test/helpers/resetDatabase');
const createCacheEntry = require('test/helpers/createCacheEntry');
const app = require('src/webserver/app');
const request = require('supertest-as-promised');
const createUser = require('test/helpers/createUser');
const createToken = require('test/helpers/createToken');
const infoMovieSuccess = require('test/fixtures/blade_runner_2049-info-success-response.json');
const assert = require("assert");
const chai = require("chai");
const chaiHttp = require("chai-http");
describe('As a user I want to request a movie', () => {
before(async () => {
await resetDatabase()
await createUser('test_user', 'test@gmail.com', 'password')
})
before(() => createCacheEntry('mi:335984:false', infoMovieSuccess));
const server = require("../../src/webserver/server");
const createUser = require("../helpers/createUser");
const createToken = require("../helpers/createToken");
const resetDatabase = require("../helpers/resetDatabase");
const createCacheEntry = require("../helpers/createCacheEntry");
const infoMovieSuccess = require("../fixtures/blade_runner_2049-info-success-response.json");
it('should return 200 when item is requested', () =>
request(app)
.post('/api/v2/request')
.set('authorization', createToken('test_user', 'secret'))
.send({ id: 335984, type: 'movie' })
.expect(200)
);
chai.use(chaiHttp);
describe("As a user I want to request a movie", () => {
beforeEach(() => resetDatabase());
beforeEach(() => createUser("test_user", "test@gmail.com", "password"));
beforeEach(() => createCacheEntry("mi:335984:false", infoMovieSuccess));
it("should return 200 when item is requested", () => {
chai
.request(server)
.post("/api/v2/request")
.set("authorization", createToken("test_user", "secret"))
.send({ id: 335984, type: "movie" })
.end((error, response) => {
assert.equal(response?.status, 200);
});
});
});