KevinMidboe/seasonedShows
1
0
Fork 0
Code Issues 20 Pull Requests 2 Packages Projects Releases 8 Wiki Activity

Fix: Tests lint and src folder (#138)

Browse Source 
* Automaticly fixable eslint issues, mostly 3 -> 2 space indentation

* fix: updated plex_userid to camelcase

* Linted and some consistency refactor on middleware

* eslint uses ecmaversion 2020 & allow empty catch rule

* Started linting source files

* Fixed eslint errors & improved a lot of error handling

* Set 2 eslint rules as warning temporarly

* Updated all import statements to be relative

* Updated mocha & nyc, resolved all lint issues in tests/

* Updated mocha & nyc. Removed production config. Updated gitignore

* Updated test commands to omit system tests, no exit code

* Updated test configuration w/ missing keys

* Chai modules defined in package.json & resolved linting errors

* Dockerfile copies development.example -> production.json. Simplified commands

* All api calls from tests use same chaiHttp implementation

Removes a list of fetch alternatives after being replaced by chaiHttp:
 - request
 - request-promise
 - supertest
 - supertest-as-promised

* Tests should use redis (mock) cache, not tmdb sqlite cache

* Disabled test asADeveloperIWantTheServerToStart

* Re-enable tests/system

* Use chaiHttp in asAUserIWantToRequestAMovie.

* Fixed redis expire & mock implmentation

* Replaced all fetch alternatives from source code and package.json

* Pass error from tmdb api back to client as errorMessage

* Updated authentication middleware to handle checks consitenctly

* Prevent assert error when checking request status, returns success 200

* Resolved merge conflicts

* Only build and publish docker container when branch master
This commit is contained in:
Kevin
2022-08-20 17:41:46 +02:00
committed by GitHub
parent 1815a429b0
commit 628ed52012
44 changed files with 1248 additions and 1592 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
tests/unit/config/testField.js
View File

@@ -1,71 +1,77 @@
const assert = require('assert');
const Field = require('src/config/field.js');
const assert = require("assert");
const Field = require("../../../src/config/field");
describe('Field', () => {
it('should return an array if it is an array', () => {
describe("Field", () => {
it("should return an array if it is an array", () => {
const field = new Field([1, 2, 3]);
assert.deepEqual(field.value, [1, 2, 3]);
});
it('should return the plain value if it is an ordinary field', () => {
const field = new Field('plain value');
assert.equal(field.value, 'plain value');
it("should return the plain value if it is an ordinary field", () => {
const field = new Field("plain value");
assert.equal(field.value, "plain value");
});
it('should return false if boolean false is field', () => {
it("should return false if boolean false is field", () => {
const field = new Field(false);
assert.equal(field.value, false);
});
it('should not include any invalid filters', () => {
const field = new Field('invalid-filter|plain value');
assert.equal(field.value, 'plain value');
it("should not include any invalid filters", () => {
const field = new Field("invalid-filter|plain value");
assert.equal(field.value, "plain value");
});
it('should return the decoded value if it is filtered through base64', () => {
const field = new Field('base64|ZW5jb2RlZCB2YWx1ZQ==');
assert.equal(field.value, 'encoded value');
it("should return the decoded value if it is filtered through base64", () => {
const field = new Field("base64|ZW5jb2RlZCB2YWx1ZQ==");
assert.equal(field.value, "encoded value");
});
it('should not decode the value if it missing the filter', () => {
const field = new Field('ZW5jb2RlZCB2YWx1ZQ==');
assert.equal(field.value, 'ZW5jb2RlZCB2YWx1ZQ==');
it("should not decode the value if it missing the filter", () => {
const field = new Field("ZW5jb2RlZCB2YWx1ZQ==");
assert.equal(field.value, "ZW5jb2RlZCB2YWx1ZQ==");
});
it('should retrieve the environment variable if env filter is used', () => {
const environmentVariables = { REDIS_URL: 'redis://127.0.0.1:1234' };
const field = new Field('env|REDIS_URL', environmentVariables);
assert.equal(field.value, 'redis://127.0.0.1:1234');
it("should retrieve the environment variable if env filter is used", () => {
const environmentVariables = { REDIS_URL: "redis://127.0.0.1:1234" };
const field = new Field("env|REDIS_URL", environmentVariables);
assert.equal(field.value, "redis://127.0.0.1:1234");
});
it('should return undefined if the environment variable does not exist', () => {
it("should return undefined if the environment variable does not exist", () => {
const environmentVariables = { HTTP_PORT: 8080 };
const field = new Field('env|REDIS_URL', environmentVariables);
const field = new Field("env|REDIS_URL", environmentVariables);
assert.equal(field.value, undefined);
});
it('should return undefined if the environment variable is an empty string', () => {
const environmentVariables = { REDIS_URL: '' };
const field = new Field('env|REDIS_URL', environmentVariables);
it("should return undefined if the environment variable is an empty string", () => {
const environmentVariables = { REDIS_URL: "" };
const field = new Field("env|REDIS_URL", environmentVariables);
assert.deepEqual(field.value, undefined);
});
describe('Multiple filters', () => {
it('should decode the environment variable if base64 and env filter are used', () => {
const environmentVariables = { REDIS_URL: 'cmVkaXM6Ly9kYWdibGFkZXQubm8vMTIzNA==' };
const field = new Field('env|base64|REDIS_URL', environmentVariables);
assert.equal(field.value, 'redis://dagbladet.no/1234');
describe("Multiple filters", () => {
it("should decode the environment variable if base64 and env filter are used", () => {
const environmentVariables = {
REDIS_URL: "cmVkaXM6Ly9kYWdibGFkZXQubm8vMTIzNA=="
};
const field = new Field("env|base64|REDIS_URL", environmentVariables);
assert.equal(field.value, "redis://dagbladet.no/1234");
});
it('should disregard the order of filters when env and base64 are used', () => {
const environmentVariables = { REDIS_URL: 'cmVkaXM6Ly9kYWdibGFkZXQubm8vMTIzNA==' };
const field = new Field('base64|env|REDIS_URL', environmentVariables);
assert.equal(field.value, 'redis://dagbladet.no/1234');
it("should disregard the order of filters when env and base64 are used", () => {
const environmentVariables = {
REDIS_URL: "cmVkaXM6Ly9kYWdibGFkZXQubm8vMTIzNA=="
};
const field = new Field("base64|env|REDIS_URL", environmentVariables);
assert.equal(field.value, "redis://dagbladet.no/1234");
});
it('should return undefined if both filters are used and env var does not exist', () => {
const environmentVariables = { REDIS_URL: 'cmVkaXM6Ly9kYWdibGFkZXQubm8vMTIzNA==' };
const field = new Field('base64|env|REDIS_LOL', environmentVariables);
it("should return undefined if both filters are used and env var does not exist", () => {
const environmentVariables = {
REDIS_URL: "cmVkaXM6Ly9kYWdibGFkZXQubm8vMTIzNA=="
};
const field = new Field("base64|env|REDIS_LOL", environmentVariables);
assert.equal(field.value, undefined);
});
});