KevinMidboe/seasonedShows
1
0
Fork 0
Code Issues 20 Pull Requests 2 Packages Projects Releases 8 Wiki Activity

Fetchall uses promises smarter. Now the utils functions also return promises to be able to nicely chain the steps a request needs to go through. Promise all lets us wait for all items return in the map function. Without the map function would return immidiately and resolve before the map operation completed.

Browse Source
This commit is contained in:
Kevin
2018-11-10 20:26:28 +01:00
parent 87eb6de802
commit 7cb55ce054
4 changed files with 28 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
seasoned_api/src/request/request.js
View File

@@ -97,22 +97,13 @@ class RequestRepository {
}
fetchAll(sort_by=undefined, sort_direction='asc', filter_param=undefined, query=undefined) {
if (sort_by !== undefined && ! utils.validSort(sort_by, sort_direction)) {
throw new Error('Invalid sort parameters')
} else if (filter_param !== undefined && ! utils.validFilter(filter_param)) {
throw new Error('Invalid filter parameter')
}
return Promise.resolve()
.then(() => utils.validSort(sort_by, sort_direction))
.then(() => utils.validFilter(filter_param))
.then(() => this.sortAndFilterToDbQuery(sort_by, sort_direction, filter_param, query))
.then((dbQuery) => this.database.all(dbQuery))
.then((rows) => Promise.all(this.mapToTmdbByType(rows)))
.catch((err) => { throw new Error(`err ${err}`) })
}
// return Promise.resolve()
// .then(() => this.database.get(this.))
// }
}
module.exports = RequestRepository;