KevinMidboe/spotify-downloader
1
0
Fork 0
mirror of https://github.com/KevinMidboe/spotify-downloader.git synced 2025-12-29 21:31:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor exceptions

Browse Source 
* Suffix names for custom exceptions with "Error"
* Introduce exceptions for when the coressponding encoder isn't found
This commit is contained in:
Ritiek Malhotra
2020-03-17 03:09:56 +05:30
parent 083c430489
commit 29005f24ed
16 changed files with 276 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spotdl/lyrics/providers/tests/test_genius.py
View File

@@ -33,5 +33,5 @@ class TestGenius:
raise urllib.request.HTTPError("", "", "", "", "")
monkeypatch.setattr("urllib.request.urlopen", mocked_urlopen)
with pytest.raises(exceptions.LyricsNotFound):
with pytest.raises(exceptions.LyricsNotFoundError):
track.get_lyrics()

4
spotdl/lyrics/providers/tests/test_lyricwikia_wrapper.py
View File

@@ -25,11 +25,11 @@ class TestLyricWikia:
def lyricwikia_lyrics_not_found(msg):
raise lyricwikia.LyricsNotFound(msg)
# Wrap `lyricwikia.LyricsNotFound` with `exceptions.LyricsNotFound` error.
# Wrap `lyricwikia.LyricsNotFoundError` with `exceptions.LyricsNotFoundError` error.
monkeypatch.setattr(
"lyricwikia.get_lyrics",
lambda a, b, c, d: lyricwikia_lyrics_not_found("Nope, no lyrics."),
)
track = LyricWikia("Lyricwikia", "Lyricwikia")
with pytest.raises(exceptions.LyricsNotFound):
with pytest.raises(exceptions.LyricsNotFoundError):
track.get_lyrics()