KevinMidboe/spotify-downloader
1
0
Fork 0
mirror of https://github.com/KevinMidboe/spotify-downloader.git synced 2025-10-29 18:00:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #584 from ritiek/fix-tests

Browse Source 
Fix tests
This commit is contained in:
Ritiek Malhotra
2019-07-22 11:07:40 +05:30
committed by GitHub
parent 5ca4317944 69522331df
commit 341af5bce9
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spotdl/internals.py
View File

@@ -258,7 +258,7 @@ def remove_duplicates(tracks):
def content_available(url): def content_available(url):
try: try:
response = urllib.request.urlopen(url) response = urllib.request.urlopen(url)
except HTTPError: except urllib.request.HTTPError:
return False return False
else: else:
return response.getcode() < 300 return response.getcode() < 300

4
test/test_patcher.py
View File

@@ -23,12 +23,12 @@ class TestMethodCalls:
def test_pafy_getbestthumb(self, content_fixture): def test_pafy_getbestthumb(self, content_fixture):
thumbnail = patcher._getbestthumb(content_fixture) thumbnail = patcher._getbestthumb(content_fixture)
assert thumbnail == "https://i.ytimg.com/vi/3nQNiWdeH2Q/maxresdefault.jpg" assert thumbnail == "https://i.ytimg.com/vi/3nQNiWdeH2Q/hqdefault.jpg"
def test_pafy_getbestthumb_without_ytdl(self, content_fixture): def test_pafy_getbestthumb_without_ytdl(self, content_fixture):
content_fixture._ydl_info["thumbnails"][0]["url"] = None content_fixture._ydl_info["thumbnails"][0]["url"] = None
thumbnail = patcher._getbestthumb(content_fixture) thumbnail = patcher._getbestthumb(content_fixture)
assert thumbnail == "https://i.ytimg.com/vi/3nQNiWdeH2Q/maxresdefault.jpg" assert thumbnail == "https://i.ytimg.com/vi/3nQNiWdeH2Q/sddefault.jpg"
def test_pafy_content_available(self): def test_pafy_content_available(self):

2
test/test_spotify_tools.py
View File

@@ -141,7 +141,7 @@ class TestFetchAlbumsFromArtist:
return albums return albums
def test_len(self, albums_from_artist_fixture): def test_len(self, albums_from_artist_fixture):
assert len(albums_from_artist_fixture) == 53 assert len(albums_from_artist_fixture) == 54
def test_zeroth_album_name(self, albums_from_artist_fixture): def test_zeroth_album_name(self, albums_from_artist_fixture):
assert albums_from_artist_fixture[0]["name"] == "Revolution Radio" assert albums_from_artist_fixture[0]["name"] == "Revolution Radio"