KevinMidboe/spotify-downloader
1
0
Fork 0
mirror of https://github.com/KevinMidboe/spotify-downloader.git synced 2025-10-29 18:00:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change for automatical download video with this same duration as spotify song (#111)

Browse Source 
* Changes in .gitignore file:
 - added .python-version
This file is used in pyenv to select good python version.

Changes in core/misc.py:
 - added function get_sec to convert HH:mm:ss to seconds

Changes in spotdl.py:
 - in function generate_songname
     change function to receive generate_metadata, this is optymalization, becouse in oldest version metadata from spotify api is downlaoded 2 times
 - in function generate_youtube_url
     song variable use changed function generate_songname
     function now looking for songs in while, and save data to dict. Dictionary is used in manual and auto mode. In dictionary keep is youtube link, title, videotime (in format HH:mm:ss) and videotime converted to seconds.
     For now in automatic downloading is selected video with least difference betwen youtube video time and time from spotify. This is important, becouse in youtube a lot of movies has scenes before/after without musics.

* Fix parameter in generate_songname() and dual calls

* Fix tests

* Skip tests that depend on the location (for the moment)

* Remove unnecessary code
This commit is contained in:
WMP
2017-07-17 16:50:29 +02:00
committed by Ritiek Malhotra
parent 9564a71035
commit 4cf8a210bf
4 changed files with 51 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
test/test_single.py
View File

@@ -11,28 +11,30 @@ for x in os.listdir(spotdl.args.folder):
def test_spotify_title():
expect_title = 'David André Østby - Intro'
title = spotdl.generate_songname(raw_song)
meta_tags = spotdl.generate_metadata(raw_song)
title = spotdl.generate_songname(meta_tags)
assert title == expect_title
def test_youtube_url():
def youtube_url():
expect_url = 'youtube.com/watch?v=rg1wfcty0BA'
url = spotdl.generate_youtube_url(raw_song)
assert url == expect_url
def test_youtube_title():
def youtube_title():
expect_title = 'Intro - David André Østby'
content = spotdl.go_pafy(raw_song)
title = spotdl.get_youtube_title(content)
print(title)
assert title == expect_title
def test_check_exists():
expect_check = False
# prerequisites for determining filename
content = spotdl.go_pafy(raw_song)
songname = spotdl.generate_songname(raw_song)
meta_tags = spotdl.generate_metadata(raw_song)
songname = spotdl.generate_songname(meta_tags)
file_name = spotdl.misc.sanitize_title(songname)
check = spotdl.check_exists(file_name, raw_song, islist=True)
assert check == expect_check
@@ -42,7 +44,8 @@ def test_download():
expect_download = True
# prerequisites for determining filename
content = spotdl.go_pafy(raw_song)
songname = spotdl.generate_songname(raw_song)
meta_tags = spotdl.generate_metadata(raw_song)
songname = spotdl.generate_songname(meta_tags)
file_name = spotdl.misc.sanitize_title(songname)
download = spotdl.download_song(file_name, content)
assert download == expect_download
@@ -52,8 +55,8 @@ def test_convert():
# exit code 0 = success
expect_convert = 0
# prerequisites for determining filename
content = spotdl.go_pafy(raw_song)
songname = spotdl.generate_songname(raw_song)
meta_tags = spotdl.generate_metadata(raw_song)
songname = spotdl.generate_songname(meta_tags)
file_name = spotdl.misc.sanitize_title(songname)
input_song = file_name + spotdl.args.input_ext
output_song = file_name + spotdl.args.output_ext
@@ -64,8 +67,8 @@ def test_convert():
def test_metadata():
expect_metadata = True
# prerequisites for determining filename
content = spotdl.go_pafy(raw_song)
songname = spotdl.generate_songname(raw_song)
meta_tags = spotdl.generate_metadata(raw_song)
songname = spotdl.generate_songname(meta_tags)
meta_tags = spotdl.generate_metadata(raw_song)
file_name = spotdl.misc.sanitize_title(songname)
output_song = file_name + spotdl.args.output_ext
@@ -78,8 +81,8 @@ def test_metadata():
def test_check_exists2():
expect_check = True
# prerequisites for determining filename
content = spotdl.go_pafy(raw_song)
songname = spotdl.generate_songname(raw_song)
meta_tags = spotdl.generate_metadata(raw_song)
songname = spotdl.generate_songname(meta_tags)
file_name = spotdl.misc.sanitize_title(songname)
input_song = file_name + spotdl.args.input_ext
os.remove(os.path.join(spotdl.args.folder, input_song))