mirror of
https://github.com/KevinMidboe/spotify-downloader.git
synced 2025-10-29 18:00:15 +00:00
Fix traceback when metadata not found
This commit is contained in:
21
spotdl.py
21
spotdl.py
@@ -14,12 +14,7 @@ import sys
|
||||
import os
|
||||
|
||||
def generate_songname(tags):
|
||||
"""Generate a string of the format '[artist] - [song]' for the given song."""
|
||||
|
||||
if tags is None:
|
||||
content = go_pafy(raw_song)
|
||||
raw_song = get_youtube_title(content)
|
||||
else:
|
||||
"""Generate a string of the format '[artist] - [song]' for the given spotify song."""
|
||||
raw_song = u'{0} - {1}'.format(tags['artists'][0]['name'], tags['name'])
|
||||
return raw_song
|
||||
|
||||
@@ -59,8 +54,11 @@ def generate_metadata(raw_song):
|
||||
|
||||
|
||||
def generate_youtube_url(raw_song):
|
||||
"""Search for the song on YouTube and generate an URL to its video."""
|
||||
"""Search for the song on YouTube and generate a URL to its video."""
|
||||
meta_tags = generate_metadata(raw_song)
|
||||
if meta_tags is None:
|
||||
song = raw_song
|
||||
else:
|
||||
song = generate_songname(meta_tags)
|
||||
search_url = misc.generate_search_url(song)
|
||||
item = urllib.request.urlopen(search_url).read()
|
||||
@@ -74,9 +72,14 @@ def generate_youtube_url(raw_song):
|
||||
y = x.find('div', class_='yt-lockup-content')
|
||||
link = y.find('a')['href']
|
||||
title = y.find('a')['title']
|
||||
try:
|
||||
videotime = x.find('span', class_="video-time").get_text()
|
||||
except AttributeError:
|
||||
return generate_youtube_url(raw_song)
|
||||
youtubedetails = {'link': link, 'title': title, 'videotime': videotime, 'seconds':misc.get_sec(videotime)}
|
||||
videos.append(youtubedetails)
|
||||
if meta_tags is None:
|
||||
break
|
||||
|
||||
if args.manual:
|
||||
print(song)
|
||||
@@ -91,6 +94,7 @@ def generate_youtube_url(raw_song):
|
||||
if result is None:
|
||||
return None
|
||||
else:
|
||||
if meta_tags is not None:
|
||||
videos.sort(key=lambda x: abs(x['seconds'] - (int(meta_tags['duration_ms'])/1000)))
|
||||
result = videos[0];
|
||||
|
||||
@@ -300,6 +304,9 @@ def grab_single(raw_song, number=None):
|
||||
|
||||
# generate file name of the song to download
|
||||
meta_tags = generate_metadata(raw_song)
|
||||
if meta_tags is None:
|
||||
songname = content.title
|
||||
else:
|
||||
songname = generate_songname(meta_tags)
|
||||
file_name = misc.sanitize_title(songname)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user