Add tests for encoders

and some refactoring

spotdl/encode/tests/test_encode_base.py

@@ -1,13 +1,101 @@
 from spotdl.encode import EncoderBase
+from spotdl.encode.exceptions import EncoderNotFoundError
 
 import pytest
 
-def test_abstract_base_class_encoderbase():
-    encoder_path = "ffmpeg"
-    _loglevel = "-hide_banner -nostats -v panic"
-    _additional_arguments = ["-b:a", "192k", "-vn"]
 
-    with pytest.raises(TypeError):
-        # This abstract base class must be inherited from
-        # for instantiation
-        EncoderBase(encoder_path, _loglevel, _additional_arguments)
+class TestAbstractBaseClass:
+    def test_error_abstract_base_class_encoderbase(self):
+        encoder_path = "ffmpeg"
+        _loglevel = "-hide_banner -nostats -v panic"
+        _additional_arguments = ["-b:a", "192k", "-vn"]
+
+        with pytest.raises(TypeError):
+            # This abstract base class must be inherited from
+            # for instantiation
+            EncoderBase(encoder_path, _loglevel, _additional_arguments)
+
+
+    def test_inherit_abstract_base_class_encoderbase(self):
+        class EncoderKid(EncoderBase):
+            def __init__(self, encoder_path, _loglevel, _additional_arguments):
+                super().__init__(encoder_path, _loglevel, _additional_arguments)
+
+            def _generate_encode_command(self):
+                pass
+
+            def _generate_encoding_arguments(self):
+                pass
+
+            def get_encoding(self):
+                pass
+
+            def re_encode(self):
+                pass
+
+            def set_argument(self):
+                pass
+
+            def set_debuglog(self):
+                pass
+
+
+        encoder_path = "ffmpeg"
+        _loglevel = "-hide_banner -nostats -v panic"
+        _additional_arguments = ["-b:a", "192k", "-vn"]
+
+        EncoderKid(encoder_path, _loglevel, _additional_arguments)
+
+
+class TestMethods:
+    class EncoderKid(EncoderBase):
+        def __init__(self, encoder_path, _loglevel, _additional_arguments):
+            super().__init__(encoder_path, _loglevel, _additional_arguments)
+
+        def _generate_encode_command(self, input_file, output_file):
+            pass
+
+        def _generate_encoding_arguments(self, input_encoding, output_encoding):
+            pass
+
+        def get_encoding(self, filename):
+            return super().get_encoding(filename)
+
+        def re_encode(self, input_encoding, output_encoding):
+            pass
+
+        def set_argument(self, argument):
+            super().set_argument(argument)
+
+        def set_debuglog(self):
+            pass
+
+
+    @pytest.fixture(scope="module")
+    def encoderkid(self):
+        encoder_path = "ffmpeg"
+        _loglevel = "-hide_banner -nostats -v panic"
+        _additional_arguments = []
+
+        encoderkid = self.EncoderKid(encoder_path, _loglevel, _additional_arguments)
+        return encoderkid
+
+    def test_set_argument(self, encoderkid):
+        encoderkid.set_argument("-parameter argument")
+        assert encoderkid._additional_arguments == [
+            "-parameter",
+            "argument",
+        ]
+
+    @pytest.mark.parametrize("filename, encoding", [
+        ("example.m4a", "m4a"),
+        ("exampley.mp3", "mp3"),
+        ("test 123.webm", "webm"),
+        ("flakey.flac", "flac"),
+    ])
+    def test_get_encoding(self, encoderkid, filename, encoding):
+        assert encoderkid.get_encoding(filename) == encoding
+
+    def test_encoder_not_found_error(self):
+        with pytest.raises(EncoderNotFoundError):
+            self.EncoderKid("/a/nonexistent/path", "0", [])

spotdl/encode/tests/test_exceptions.py

@@ -6,6 +6,9 @@ import pytest
 
 
 class TestEncoderNotFoundSubclass:
+    def test_encoder_not_found_subclass(self):
+        assert issubclass(FFmpegNotFoundError, Exception)
+
     def test_ffmpeg_not_found_subclass(self):
         assert issubclass(FFmpegNotFoundError, EncoderNotFoundError)