Linus
0f384bb5ee
Add docstrings; Remove verbose comments; Fix errors introduced with cleanup
...
This comment will:
- Transform docstrings above functions into docstrings
- Remove some way too verbose comments
- Apply some more recommendations from PEP8 forgotten last time
- Fix some errors introduced with the first code cleanup
Work left to do:
- Add params to docstrings
- Rename file variables
2017-06-28 16:21:58 +02:00
Linus
587f907ed8
Apply most best practices of PEP 8
...
This refactoring includes:
- Two empty lines before each global function
- Using '{0} {1}'.format(str1, str2) instead of str1 + ' ' + str2
Sometimes this will make lines longer, sometimes shorter.
- Starting all comments with # + space + comment
- Make lines not longer than 80 characters in most cases
- Renaming some variables to make more sense
- Add some missing code like returns and Exceptions
Not included, but follows:
- Make some comments docstrings
- Rename all 'file' variables, only for Python 2
- Remove some way too verbose comments ;)
2017-06-28 16:21:58 +02:00
Linus Groh
4132e414c4
Add check for nonexistent playlists showing up for some reason ( #92 )
2017-06-27 14:01:49 +05:30
Ritiek
8af2479389
Update mechanism for fetching playlist tracks
2017-06-26 19:44:02 +05:30
Ritiek Malhotra
e90b5a4b4e
Fetches all user playlists now (was limited to 50)
2017-06-26 19:18:22 +05:30
Ritiek Malhotra
1e3631401a
Merge branch 'master' into develop
2017-06-26 02:24:29 +05:30
Ritiek
9e2a5751d3
Fix error on conversion in python3
2017-06-25 20:51:59 +05:30
Ritiek
e18a74ccc3
Add metadata test
2017-06-25 02:34:55 +05:30
Ritiek
93244e46ec
Fix download test
2017-06-25 01:16:04 +05:30
Ritiek
142d14118b
Add more basic tests
2017-06-25 01:05:25 +05:30
Ritiek
0dfaf183b5
Test YouTube track title
2017-06-25 00:31:57 +05:30
Ritiek
69634475ad
Test spotify generated songname
2017-06-25 00:04:21 +05:30
Ritiek
ae29ff8f87
Split conversion code
2017-06-24 21:49:19 +05:30
Ritiek
fb3c7e9ec3
Improve metadata fixing mechanism
2017-06-24 20:38:06 +05:30
Ritiek
23e44c1158
Skip if copyright info unavailable
2017-06-23 09:47:29 +05:30
Ritiek
5eba56d125
Message if audio stream not available on YouTube
2017-06-22 13:45:43 +05:30
Ritiek
258b21ff05
Fix getting input in python3
2017-06-22 02:27:18 +05:30
Ritiek
acfb2f0173
Fix encoding problems hopefully
2017-06-21 14:13:32 +05:30
Ritiek
5aa8c66db3
Small encoding changes
2017-06-21 12:58:15 +05:30
Ritiek
9d0e769060
Rename function
2017-06-21 01:02:21 +05:30
Ritiek
0c328079a8
Fix encoding problems in python2
2017-06-21 00:34:24 +05:30
Ritiek Malhotra
464189060f
Fix some encoding problems
2017-06-20 22:24:20 +05:30
Ritiek
20d4d7c2d5
Change defaults to FFmpeg
2017-06-20 20:25:47 +05:30
Ritiek
ccf2c818a0
Small updates
2017-06-19 23:23:24 +05:30
Ritiek
ab51545d64
Use subprocess.call() for FFmpeg
2017-06-18 03:52:14 +05:30
Ritiek
086dc846bd
Bug fix change tag to tags
2017-06-18 03:27:36 +05:30
Ritiek
80c167e702
Add lots of comments
2017-06-18 02:57:55 +05:30
Ritiek
c270aa8365
Message on unavailable local tracks
2017-06-18 02:16:25 +05:30
Ritiek
e2af7bf1f3
Small fixes
2017-06-16 22:07:42 +05:30
Ritiek Malhotra
a2770badb6
Fix variable names
2017-06-16 21:18:35 +05:30
Ritiek Malhotra
303fe813be
Improve code readability
2017-06-16 21:17:06 +05:30
Ritiek
44f34555b4
Use urllib2.quote() to fix encoding errors
2017-06-16 20:53:30 +05:30
Ritiek Malhotra
1071eb3d75
Remove necessary exceptions
2017-06-16 18:40:39 +05:30
Ritiek
5fcdc3c227
Fix imports for python3
2017-06-16 18:04:08 +05:30
Ritiek Malhotra
4547ef7e71
Capture TypeError
2017-06-16 16:39:47 +05:30
Ritiek Malhotra
24636d2d47
Revert
2017-06-16 16:35:35 +05:30
Ritiek Malhotra
70f18067db
Capture requests.exception.ConnectionError
2017-06-16 16:21:31 +05:30
Ritiek
5d3c27b622
Import misc
2017-06-16 14:53:02 +05:30
Ritiek
280ff41633
Make functions and class names a little verbose
2017-06-16 14:40:12 +05:30
Ritiek
e9c247ead9
Switch to class for embedding metadata
2017-06-16 14:35:14 +05:30
Ritiek
06853a03d4
Separate module for embedding metadata
2017-06-16 13:32:40 +05:30
Ritiek Malhotra
b1647ee76b
Fix a syntax error
2017-06-16 12:39:36 +05:30
Ritiek Malhotra
34ae941d63
No need to import spotipy.oauth2.SpotifyOauthError
2017-06-16 12:38:28 +05:30
Ritiek Malhotra
67f579a03a
Fix embedding multiple artists
2017-06-16 02:50:01 +05:30
Ritiek
f1e5913e6e
Automatically refresh token when expired when downloading from list
2017-06-16 02:37:01 +05:30
Ritiek
74511cf596
Fix check_exists() from giving prompts on non-existent files
2017-06-16 02:06:08 +05:30
Ritiek Malhotra
be088f6dc0
Handle URLError and IOError when network problem
2017-06-16 00:24:09 +05:30
Ritiek Malhotra
10f57b4ae5
Revert debug modifications
2017-06-15 23:33:59 +05:30
Ritiek
f841a38169
Add all artists in metadata
2017-06-15 22:20:27 +05:30
Ritiek
7f029af5c6
Minor changes
2017-06-15 20:54:57 +05:30