KevinMidboe/spotify-downloader
1
0
Fork 0
mirror of https://github.com/KevinMidboe/spotify-downloader.git synced 2025-10-29 18:00:15 +00:00
Code Issues Packages Projects Releases Wiki Activity
944 Commits 3 Branches 17 Tags
d53a6ea471e121049dc8b25555f6f1c5ce7368c6
Commit Graph

944 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
ifduyue
67ae7d5c4c Add missing import time (#465) 
This fixes #464
 2019-01-04 09:56:21 +00:00
Ritiek Malhotra
f4d8bd0c8c Update CHANGES.md (#461) v1.1.1 2019-01-02 19:34:58 +00:00
Ritiek Malhotra
b58c4775f2 Run black formatter on the whole codebase (#460) 2019-01-02 19:22:50 +00:00
Ritiek Malhotra
8c3c4c251b Merge branch 'release-v1.1.1' 2019-01-03 00:43:55 +05:30
Ritiek Malhotra
c6bc994658 Fix conflicts caused by merge of #459 2019-01-03 00:43:37 +05:30
Ritiek Malhotra
53dd292b55 Fix conversion conflicts when both input and output filenames are same (#459) 
* Workaround conversion conflicts by appending '.temp' to input filename

* Fix tests

* Add a test and some minor changes

* Update CHANGES.md
 2019-01-02 18:54:27 +00:00
Ritiek Malhotra
2ce0857f92 Update CHANGES.md 2018-12-29 15:30:40 +05:30
Ritiek Malhotra
0d0a85b761 Some updates for using spotdl as library 2018-12-29 14:56:00 +05:30
Ritiek Malhotra
9f09a13063 Specify encoding for README.md so unicode characters are dealt with correctly 2018-12-29 14:10:31 +05:30
Ritiek Malhotra
fbc04671d8 Use Black to format code 2018-12-29 14:09:34 +05:30
Ritiek Malhotra
a4493a1e5f Bump to v1.1.1 2018-12-29 14:08:58 +05:30
Amit Lawanghare
1cf421960c Issue with Spotify-url and --no-metadata #452 (#454) 
* Applied a check on null result in case of no youtube search

* Allow fetch metadata from spotify upon searching spotify-url and no-metadata

* updated changes.md

* Updated CHANGES.md as per suggestion

* removed unnecessary bool hit

Co-Authored-By: Amit-L <amit.lawanghare@gmail.com>

* removed unnecessary bool hit, anti PEP 8

Co-Authored-By: Amit-L <amit.lawanghare@gmail.com>

* resolved conflicts

* Error shown no videos found

* Dont to show any manual option for no result
 2018-12-29 14:05:24 +05:30
Ritiek Malhotra
51b01fc448 [WIP] Monkeypatch tests (#448) 
* Parameterize test_internals.py

* Create test_spotify_tools.py

* Monkeypatch pafy.download

* Monkeypatch YouTube search page

* Replace globals with fixtures

* Add missing urllib import, re-ordering and rename test_with_metadata.py

* Avoid creating temp directory in current working directory during test

* Update CHANGES.md
 2018-12-26 17:15:56 +05:30
Linus Groh
bfe958dadc Merge pull request #453 from ritiek/fix-incorrect-metadata-m4a 
Fix .m4a containers
 2018-12-25 15:20:58 +01:00
Ritiek Malhotra
018fb5d7f0 Update CHANGES.md 2018-12-25 19:48:06 +05:30
Ritiek Malhotra
9170ff22a7 Surround filename in quotes 2018-12-25 19:34:49 +05:30
Ritiek Malhotra
a0847f19b9 Fix .m4a containers 2018-12-25 19:32:49 +05:30
Linus Groh
9652ecac27 Merge pull request #444 from ritiek/update-faq-section 
Remove question links from FAQ section
 2018-12-18 13:15:04 +01:00
Ritiek Malhotra
1a16a55db1 Remove question links from FAQ section 2018-12-09 20:46:07 +05:30
Linus Groh
44f64530ef Merge pull request #442 from ritiek/download-multiple-tracks 
Pass multiple tracks at once in --song argument
 2018-12-04 18:01:41 +01:00
Ritiek Malhotra
8d7dc762de Add a changelog entry 2018-12-04 20:38:30 +05:30
Ritiek Malhotra
9e6d7cdc99 Pass multiple tracks at once in --song argument 2018-12-03 21:47:57 +05:30
Linus Groh
3df87ab763 Merge pull request #440 from ritiek/fix-missing-import 
Import spotipy in downloader.py
 2018-12-02 17:11:05 +01:00
Ritiek Malhotra
608c53f759 Fixed: Missing import spotipy 2018-12-02 12:22:02 +05:30
Ritiek Malhotra
1e34124de9 Import spotipy in downloader.py 2018-12-02 12:16:02 +05:30
Ritiek Malhotra
eae9316cee [WIP] Refactor spotdl.py; introduced classes (#410) 
* Refactor spotdl.py; introduced classes

* introduce CheckExists class

* Move these classes to download.py

* Fix refresh_token

* Add a changelog entry
 2018-11-25 17:07:56 +05:30
Linus Groh
8ced90cb39 Add Python 3.7 to Travis CI tests (#429) 
* Add Python 3.7 to Travis CI tests

* Update Travis config to use Xenial
 2018-11-18 19:48:33 +05:30
Linus Groh
f1d7d19a6c Merge pull request #432 from ritiek/compact-issue-template 
Update issue template to mention latest version and similar issues as comments
 2018-11-15 20:17:14 +01:00
Ritiek Malhotra
47ab429a05 Change latest version and similar issues to comments 2018-11-15 12:27:36 +05:30
Linus Groh
6f6d95b2f9 Change colon format emoji to Unicode character (#428) 2018-11-14 10:11:45 +05:30
Ritiek Malhotra
f0ab90719b Bump to v1.1.0 (#427) v1.1.0 2018-11-13 23:28:52 +05:30
Linus Groh
41a5758a63 Merge pull request #426 from ritiek/rere-fix-tests 
Rere-fix tests
 2018-11-13 17:21:49 +01:00
Ritiek Malhotra
c685fa2bfd Rere-fix tests 2018-11-13 21:27:21 +05:30
Linus Groh
b18a17c2a1 Update CONTRIBUTING.md (#425) 2018-11-13 20:50:33 +05:30
Linus Groh
a0d9667660 Update CHANGES.md for upcoming 1.1.0 release (#424) 2018-11-13 20:48:09 +05:30
Manveer Basra
20b5e44ed4 --list flag accepts only text files using mimetypes (#414) 
* --list flag accepts only text files using mimetypes

* Refactored for consistency

* Workaround to make tests pass
 2018-10-29 23:00:35 -07:00
Ritiek Malhotra
be4bb25c96 Filter unwanted text from Spotify URLs when extracting information (#394) 
* Split unwanted URL part

* Convert get_splits() -> extract_spotify_id()

* Add tests for extract_spotify_id()

* Extract Spotify artist ID when fetching artist albums
 2018-10-26 18:29:29 +05:30
Manveer Basra
94dc27a77b Refactored refresh token (#408) 
* Outputs error details when track download fails from list file

* Refactored Spotipy token refreshing

* Reverted to old refreshing method

Kept refresh_token() in spotify_tools.py
 2018-10-25 20:00:46 +05:30
Manveer Basra
680525ea3d Outputs error details when track download fails from list file (#406) 2018-10-24 22:06:39 +05:30
Manveer Basra
94f0b3e95d Doesn't search song on Spotify if "--no-metadata" passed (#404) 
* Doesn't search song on Spotify if '--no-metadata' passed

* Doesn't search song on Spotify if '--no-metadata' passed

* Doesn't war user that 'no metadata found' if '--no-metadata' passed
 2018-10-23 17:27:12 +05:30
Ritiek Malhotra
f65034f17e Create a custom user for tests (#405) 2018-10-22 23:03:06 +05:30
Manveer Basra
acff5fc8e2 Check and replace slashes with dashes to avoid directory creation error (#402) 
* Added check for track titles containing slashes

* Revert white-space typos

* Added check for windows backslash

* Added check for non-string filename titles
 2018-10-21 14:21:31 +05:30
Ritiek Malhotra
b12ca8c785 Add support for .m3u playlists (#401) 
* Add support for .m3u playlists

* Run black code formatter on changes

* Stay consistent with Spotify test track
 2018-10-20 16:19:14 +05:30
Manveer Basra
7d321d9616 Changed test track to one whose lyrics are found (#400) 
* Changed test track to one whose lyrics are found

* Fixed incorrect values

* Update playlists test to reflect change in playlist
 2018-10-19 20:25:50 +05:30
AlfredoSequeida
2b42f0b3a1 added the ability to get all artist's songs as suggested by #366 (#389) 
* added the ability to get all artist's songs as suggested by #366

* added log to featch_all_albums_from_artist function and removed the use of a uri

* updated the functionality to get all albums with the ability to get singles

* updated main function with new write_all_albums_from_artist function to get all albums from an artist

* fixed typos

* updated test case for getting all albums from artist

* fixed typos
 2018-10-10 23:53:10 -07:00
Linus Groh
e554b4252c Move black badge before gitter badge (#395) 2018-10-09 03:14:48 -07:00
Linus Groh
8eb16a6fe3 Merge pull request #379 from ritiek/comment-metadata 
Embed comment metadata in .m4a
 2018-10-09 11:28:58 +02:00
Ritiek Malhotra
519fe75eac Merge branch 'master' into comment-metadata 2018-10-09 01:30:06 -07:00
Linus Groh
13c83bd225 Introduce usage of black (code formatter) (#393) 2018-10-09 00:57:11 -07:00
Sam Redmond
71ee6ad5e2 Windows - 'My Music' folder won't be assumed to be on C drive (#387) 
* Windows - 'My Music' folder won't be assumed to be on C drive

Windows has a nice registry check to get the absolute path of the 'My Music' folder. This helps because some people change their location of their music folder.

* Updated according to suggestions

Let me know if there are anymore improvements 👍

* Fixups
 2018-10-09 00:25:45 -07:00