Request wine front & backend talk nicer togheter.
- requestWineController validates wine object and returns helpfull error repsonse if anything is missing. - requestWine uses new endpoint and calls api from within itself. - Linting.
This commit is contained in:
@@ -1,10 +1,11 @@
|
||||
const path = require("path");
|
||||
const RequestRepository = require(path.join(__dirname, "../request"));
|
||||
const requestRepository = require(path.join(__dirname, "../request"));
|
||||
|
||||
function addRequest(req, res) {
|
||||
const { wine } = req.body;
|
||||
|
||||
return RequestRepository.addNew(wine)
|
||||
return verifyWineValues(wine)
|
||||
.then(_ => requestRepository.addNew(wine))
|
||||
.then(wine =>
|
||||
res.json({
|
||||
message: "Successfully added new request",
|
||||
@@ -23,7 +24,8 @@ function addRequest(req, res) {
|
||||
}
|
||||
|
||||
function allRequests(req, res) {
|
||||
return RequestRepository.getAll()
|
||||
return requestRepository
|
||||
.getAll()
|
||||
.then(wines =>
|
||||
res.json({
|
||||
wines: wines,
|
||||
@@ -31,12 +33,10 @@ function allRequests(req, res) {
|
||||
})
|
||||
)
|
||||
.catch(error => {
|
||||
console.log("error in getAllRequests:", error);
|
||||
|
||||
const message = "Unable to fetch all requested wines.";
|
||||
return res.status(500).json({
|
||||
const { message, statusCode } = error;
|
||||
return res.status(statusCode || 500).json({
|
||||
success: false,
|
||||
message: message
|
||||
message: message || "Unable to fetch all requested wines."
|
||||
});
|
||||
});
|
||||
}
|
||||
@@ -44,7 +44,8 @@ function allRequests(req, res) {
|
||||
function deleteRequest(req, res) {
|
||||
const { id } = req.params;
|
||||
|
||||
return RequestRepository.deleteById(id)
|
||||
return requestRepository
|
||||
.deleteById(id)
|
||||
.then(_ =>
|
||||
res.json({
|
||||
message: `Slettet vin med id: ${id}`,
|
||||
@@ -61,6 +62,41 @@ function deleteRequest(req, res) {
|
||||
});
|
||||
}
|
||||
|
||||
function verifyWineValues(wine) {
|
||||
return new Promise((resolve, reject) => {
|
||||
if (wine == undefined) {
|
||||
reject({
|
||||
message: "No wine object found in request body.",
|
||||
status: 400
|
||||
});
|
||||
}
|
||||
|
||||
if (wine.id == null) {
|
||||
reject({
|
||||
message: "Wine object missing value id.",
|
||||
status: 400
|
||||
});
|
||||
} else if (wine.name == null) {
|
||||
reject({
|
||||
message: "Wine object missing value name.",
|
||||
status: 400
|
||||
});
|
||||
} else if (wine.vivinoLink == null) {
|
||||
reject({
|
||||
message: "Wine object missing value vivinoLink.",
|
||||
status: 400
|
||||
});
|
||||
} else if (wine.image == null) {
|
||||
reject({
|
||||
message: "Wine object missing value image.",
|
||||
status: 400
|
||||
});
|
||||
}
|
||||
|
||||
resolve();
|
||||
});
|
||||
}
|
||||
|
||||
module.exports = {
|
||||
addRequest,
|
||||
allRequests,
|
||||
|
||||
Reference in New Issue
Block a user