KevinMidboe/vinlottis
1
0
Fork 0
Code Issues 8 Pull Requests 14 Packages Projects Releases Wiki Activity

Better validation and error resp validating wines.

Browse Source
This commit is contained in:
Kevin
2021-02-18 21:06:49 +01:00
parent d0fa89b92b
commit 9823197a48
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
api/controllers/lotteryWineController.js
View File

@@ -21,7 +21,7 @@ const allWines = (req, res) => {
}; };
const addWines = (req, res) => { const addWines = (req, res) => {
const { wines } = req.body; let { wines } = req.body;
if (!(wines instanceof Array)) { if (!(wines instanceof Array)) {
return res.status(400).send({ return res.status(400).send({
@@ -36,7 +36,7 @@ const addWines = (req, res) => {
return Promise.all( return Promise.all(
requiredAttributes.map(attr => { requiredAttributes.map(attr => {
if (typeof wine[attr] === "undefined") { if (typeof wine[attr] === "undefined" || wine[attr] == "") {
return Promise.reject({ return Promise.reject({
message: `Incorrect or missing attribute: ${attr}.`, message: `Incorrect or missing attribute: ${attr}.`,
statusCode: 400, statusCode: 400,
@@ -96,6 +96,13 @@ const updateWineById = (req, res) => {
const { id } = req.params; const { id } = req.params;
const { wine } = req.body; const { wine } = req.body;
if (id == null || id == "undefined") {
return res.status(400).send({
message: "Unable to update without id.",
success: false
});
}
return prelotteryWineRepository return prelotteryWineRepository
.updateWineById(id, wine) .updateWineById(id, wine)
.then(updatedWine => { .then(updatedWine => {