KevinMidboe/vinlottis
1
0
Fork 0
Code Issues 8 Pull Requests 14 Packages Projects Releases Wiki Activity

Add navigation to the banner #25

Merged
Adrianht merged 7 commits from feat/navigation-in-header into master 2020-09-07 14:57:40 +00:00
Conversation 4 Commits 7 Files Changed 3 +246 -54
Adrianht commented 2020-09-01 12:12:53 +00:00 (Migrated from github.com)
Copy Link

Idea

Create a way for the users to navigate the site without needing knowledge of what routes are available.

Functionality

Screen Recording 2020-09-02 at 12 59 47

## Idea Create a way for the users to navigate the site without needing knowledge of what routes are available. ## Functionality ![Screen Recording 2020-09-02 at 12 59 47](https://user-images.githubusercontent.com/22147672/91973315-56d6b400-ed1c-11ea-9459-7ae0d5fd8ab4.gif)
KevinMidboe (Migrated from github.com) reviewed 2020-09-07 08:01:03 +00:00
src/Vinlottis.vue
@@ -28,1 +47,4 @@
route: "/requested-wines"
},
]
};
KevinMidboe (Migrated from github.com) commented 2020-09-02 08:10:33 +00:00
Copy Link

Remove

Remove
KevinMidboe (Migrated from github.com) commented 2020-09-02 08:13:10 +00:00
Copy Link

We could toggle with class mobile-only/desktop-only.

We could toggle with class `mobile-only`/`desktop-only`.
src/ui/Banner.vue
@@ -1,18 +1,36 @@
<template>
KevinMidboe (Migrated from github.com) commented 2020-09-02 08:11:38 +00:00
Copy Link

rename class plz

rename class plz
Adrianht (Migrated from github.com) reviewed 2020-09-07 14:33:30 +00:00
src/Vinlottis.vue
@@ -28,1 +47,4 @@
route: "/requested-wines"
},
]
};
Adrianht (Migrated from github.com) commented 2020-09-07 14:33:29 +00:00
Copy Link

fixed

fixed
Adrianht (Migrated from github.com) reviewed 2020-09-07 14:33:35 +00:00
src/ui/Banner.vue
@@ -1,18 +1,36 @@
<template>
Adrianht (Migrated from github.com) commented 2020-09-07 14:33:34 +00:00
Copy Link

fixed

fixed
Adrianht (Migrated from github.com) reviewed 2020-09-07 14:33:39 +00:00
src/Vinlottis.vue
@@ -28,1 +47,4 @@
route: "/requested-wines"
},
]
};
Adrianht (Migrated from github.com) commented 2020-09-07 14:33:39 +00:00
Copy Link

fixed

fixed
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
feature
good first issue
Good for newcomers
greenkeeper
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
refactor
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KevinMidboe
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KevinMidboe/vinlottis#25
No description provided.
Delete Branch "feat/navigation-in-header"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?