KevinMidboe/vinlottis
1
0
Fork 0
Code Issues 8 Pull Requests 14 Packages Projects Releases Wiki Activity

Feat/highscore page #30

Merged
KevinMidboe merged 6 commits from feat/highscore-page into master 2020-09-08 08:56:56 +00:00
Conversation 4 Commits 6 Files Changed 6 +314 -10
KevinMidboe commented 2020-09-06 20:44:41 +00:00 (Migrated from github.com)
Copy Link

Idea

Page to view your and others ranking and what colors and wines where won per user.

Art

Landing view:
Screen Shot 2020-09-06 at 22 35 30

Searched and selected person "Claus Bugge":
Screen Shot 2020-09-06 at 22 36 51

Changes/commits

  • Person highscore overview page. ace2227
  • More positioning and global style rules. 2cc5c81
  • Highscore has viewmore link for highscorePage. 9174338
  • Moved link styling to global.scss. 34216c2
## Idea Page to view your and others ranking and what colors and wines where won per user. ## Art Landing view: <img width="1010" alt="Screen Shot 2020-09-06 at 22 35 30" src="https://user-images.githubusercontent.com/2287769/92334874-267f7480-f092-11ea-8a19-2b0bdd342157.png"> Searched and selected person "Claus Bugge": <img width="1009" alt="Screen Shot 2020-09-06 at 22 36 51" src="https://user-images.githubusercontent.com/2287769/92334907-76f6d200-f092-11ea-9bda-f491449eabec.png"> ## Changes/commits - Person highscore overview page. [ace2227](https://github.com/KevinMidboe/vinlottis/commit/ace222749a9d050323b1a6769578f4c7cd633b0b) - More positioning and global style rules. [2cc5c81](https://github.com/KevinMidboe/vinlottis/commit/2cc5c81df603c59f99a996c7dcec9538668f3d78) - Highscore has viewmore link for highscorePage. [9174338](https://github.com/KevinMidboe/vinlottis/commit/9174338621397d124219c85ca8f73de779186827) - Moved link styling to global.scss. [34216c2](https://github.com/KevinMidboe/vinlottis/commit/34216c2708829c1507e8f8906d2de816188d382c)
KevinMidboe (Migrated from github.com) reviewed 2020-09-07 08:46:23 +00:00
src/components/HighscorePage.vue
@@ -0,0 +164,4 @@
margin-top: 2rem;
}
.color-box {
KevinMidboe (Migrated from github.com) commented 2020-09-07 08:46:23 +00:00
Copy Link

Move this to more general place and remove other local references to this class.

Move this to more general place and remove other local references to this class.
Adrianht (Migrated from github.com) reviewed 2020-09-08 08:03:28 +00:00
Adrianht (Migrated from github.com) left a comment
Copy Link

Include this a route to this page in Vinlottis.vue so it's available from the banner

Include this a route to this page in Vinlottis.vue so it's available from the banner
Adrianht (Migrated from github.com) reviewed 2020-09-08 08:06:11 +00:00
src/components/HighscorePage.vue
Adrianht (Migrated from github.com) commented 2020-09-08 08:06:10 +00:00
Copy Link

remove

remove
KevinMidboe (Migrated from github.com) reviewed 2020-09-08 08:25:14 +00:00
src/components/HighscorePage.vue
KevinMidboe (Migrated from github.com) commented 2020-09-08 08:25:13 +00:00
Copy Link

Tyty, fixed

Tyty, fixed
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
feature
good first issue
Good for newcomers
greenkeeper
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
refactor
wontfix
This will not be worked on
No Label
feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KevinMidboe
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KevinMidboe/vinlottis#30
No description provided.
Delete Branch "feat/highscore-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?