Rework the banner #34

Merged

Adrianht merged 7 commits from enhancement/header-rework into master 2020-09-09 07:54:42 +00:00

Conversation 8 Commits 7 Files Changed 11 +213 -200

Adrianht commented 2020-09-08 14:18:42 +00:00 (Migrated from github.com)

Copy Link

Idea

The banner/navigation was pretty ugly, so I reworked it to be better looking with some cool animations.

Also added a link-color variable to variables.scss

Functionality

## Idea The banner/navigation was pretty ugly, so I reworked it to be better looking with some cool animations. Also added a link-color variable to variables.scss ## Functionality 

KevinMidboe (Migrated from github.com) reviewed 2020-09-08 14:54:39 +00:00

src/ui/Banner.vue

KevinMidboe (Migrated from github.com) commented 2020-09-08 14:50:42 +00:00

Copy Link

is this height? or state.

is this height? or state.

KevinMidboe (Migrated from github.com) commented 2020-09-08 14:50:51 +00:00

Copy Link

Should it be boolean?

Should it be boolean?

KevinMidboe commented 2020-09-08 14:55:26 +00:00 (Migrated from github.com)

Copy Link

Remove Banner references from VinlottisPage.vue.

Remove `Banner` references from `VinlottisPage.vue`.

KevinMidboe (Migrated from github.com) reviewed 2020-09-08 15:02:08 +00:00

src/ui/Banner.vue

KevinMidboe (Migrated from github.com) commented 2020-09-08 15:02:08 +00:00

Copy Link

    <nav class="menu" :class="{ 'desktop-only': isOpen }">

```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```

Adrianht (Migrated from github.com) reviewed 2020-09-09 07:21:33 +00:00

src/ui/Banner.vue

Adrianht (Migrated from github.com) commented 2020-09-09 07:21:33 +00:00

Copy Link

fixed

fixed

Adrianht (Migrated from github.com) reviewed 2020-09-09 07:21:37 +00:00

src/ui/Banner.vue

Adrianht (Migrated from github.com) commented 2020-09-09 07:21:37 +00:00

Copy Link

fixed

fixed

Adrianht (Migrated from github.com) reviewed 2020-09-09 07:29:26 +00:00

src/ui/Banner.vue

Adrianht (Migrated from github.com) commented 2020-09-09 07:29:26 +00:00

Copy Link

    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >

```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```

Adrianht (Migrated from github.com) reviewed 2020-09-09 07:30:22 +00:00

src/ui/Banner.vue

Adrianht (Migrated from github.com) commented 2020-09-09 07:30:22 +00:00

Copy Link

    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >

```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```

Adrianht (Migrated from github.com) reviewed 2020-09-09 07:30:40 +00:00

src/ui/Banner.vue

Adrianht (Migrated from github.com) commented 2020-09-09 07:30:39 +00:00

Copy Link

        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>

```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

dependencies

Pull requests that update a dependency file

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

feature

good first issue

Good for newcomers

greenkeeper

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

refactor

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

KevinMidboe

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KevinMidboe/vinlottis#34

No description provided.