KevinMidboe/vinlottis
1
0
Fork 0
Code Issues 8 Pull Requests 14 Packages Projects Releases Wiki Activity

Confetti for the winners #37

Merged
guggerud merged 3 commits from feat/confetti into master 2020-09-11 07:47:50 +00:00
Conversation 10 Commits 3 Files Changed 3 +248 -223
guggerud commented 2020-09-10 12:15:05 +00:00 (Migrated from github.com)
Copy Link

WOULD BE NICE WITH A DESCRIPTION AND REFERENCE TO THE RELATED ISSUE:)

WOULD BE NICE WITH A DESCRIPTION AND REFERENCE TO THE RELATED ISSUE:)
KevinMidboe (Migrated from github.com) reviewed 2020-09-10 12:19:53 +00:00
src/ui/WinnerDraw.vue
KevinMidboe (Migrated from github.com) commented 2020-09-10 12:17:15 +00:00
Copy Link

Instead of having a check here how about only calling startConfetti() and have it check what the name is and either do normal size or uber size?

Instead of having a check here how about only calling `startConfetti()` and have it check what the name is and either do normal size or uber size?
src/ui/WinnerDraw.vue
@@ -147,9 +150,39 @@ export default {
case 3:
return "yellow";
}
KevinMidboe (Migrated from github.com) commented 2020-09-10 12:19:41 +00:00
Copy Link

This is pretty similar to the function above. Can some of the code be separated into a more general function and instead send defaults or confetti objects down to the more general function?

This is pretty similar to the function above. Can some of the code be separated into a more general function and instead send `defaults` or confetti objects down to the more general function?
src/ui/WinnerDraw.vue
@@ -151,2 +181,4 @@
}
},
}
};
KevinMidboe (Migrated from github.com) commented 2020-09-10 12:17:36 +00:00
Copy Link

Nice with a comment that explains the size in seconds here.

Nice with a comment that explains the size in seconds here.
guggerud (Migrated from github.com) reviewed 2020-09-10 12:22:06 +00:00
src/ui/WinnerDraw.vue
guggerud (Migrated from github.com) commented 2020-09-10 12:22:06 +00:00
Copy Link

Good idea! Thanks for the input

Good idea! Thanks for the input
guggerud (Migrated from github.com) reviewed 2020-09-10 12:23:07 +00:00
src/ui/WinnerDraw.vue
@@ -151,2 +181,4 @@
}
},
}
};
guggerud (Migrated from github.com) commented 2020-09-10 12:23:07 +00:00
Copy Link

I will include a comment to be more descriptive, thanks!

I will include a comment to be more descriptive, thanks!
KevinMidboe commented 2020-09-10 12:25:22 +00:00 (Migrated from github.com)
Copy Link

Also, how about having some minor randomness in the size of the normal confetti for variety?

Also, how about having some minor randomness in the size of the normal confetti for variety?
guggerud (Migrated from github.com) reviewed 2020-09-10 12:25:44 +00:00
src/ui/WinnerDraw.vue
@@ -147,9 +150,39 @@ export default {
case 3:
return "yellow";
}
guggerud (Migrated from github.com) commented 2020-09-10 12:25:44 +00:00
Copy Link

I should indeed be able to reduce redundancy here!

I should indeed be able to reduce redundancy here!
guggerud (Migrated from github.com) reviewed 2020-09-10 14:51:22 +00:00
src/ui/WinnerDraw.vue
guggerud (Migrated from github.com) commented 2020-09-10 14:51:22 +00:00
Copy Link

Fixed

Fixed
guggerud (Migrated from github.com) reviewed 2020-09-10 14:51:32 +00:00
src/ui/WinnerDraw.vue
@@ -151,2 +181,4 @@
}
},
}
};
guggerud (Migrated from github.com) commented 2020-09-10 14:51:32 +00:00
Copy Link

Fixed

Fixed
guggerud (Migrated from github.com) reviewed 2020-09-10 14:51:39 +00:00
src/ui/WinnerDraw.vue
@@ -147,9 +150,39 @@ export default {
case 3:
return "yellow";
}
guggerud (Migrated from github.com) commented 2020-09-10 14:51:39 +00:00
Copy Link

fixed

fixed
KevinMidboe (Migrated from github.com) reviewed 2020-09-11 07:30:40 +00:00
src/ui/WinnerDraw.vue
KevinMidboe (Migrated from github.com) commented 2020-09-11 07:29:55 +00:00
Copy Link

What is x & y here? Can we give them more descriptive names?

What is `x` & `y` here? Can we give them more descriptive names?
KevinMidboe (Migrated from github.com) approved these changes 2020-09-11 07:46:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
KevinMidboe
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
feature
good first issue
Good for newcomers
greenkeeper
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
refactor
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KevinMidboe
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KevinMidboe/vinlottis#37
No description provided.
Delete Branch "feat/confetti"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?