KevinMidboe/vinlottis
1
0
Fork 0
Code Issues 8 Pull Requests 14 Packages Projects Releases Wiki Activity

Feat/history page by date #46

Merged
KevinMidboe merged 6 commits from feat/history-page-by-date into master 2020-10-11 16:22:11 +00:00
Conversation 0 Commits 6 Files Changed 4 +91 -73
KevinMidboe commented 2020-10-11 13:33:30 +00:00 (Migrated from github.com)
Copy Link

Now the frontend page history get receive an epoch date and it will fetch only date history element.
Refactored the lottery controller. Improvements:

  • /latest resolves wine references.
  • Better error handling if /by-date or /by-name does not find anything for the requested value.
  • Moved functionality to be isolated within function that does a give task.

Changes/commits:

  • New api route from history by date.
  • If date in params, fetch only that date.
  • Refactored lottery controller.´
Now the frontend page history get receive an epoch date and it will fetch only date history element. Refactored the lottery controller. Improvements: - /latest resolves wine references. - Better error handling if /by-date or /by-name does not find anything for the requested value. - Moved functionality to be isolated within function that does a give task. Changes/commits: - New api route from history by date. - If date in params, fetch only that date. - Refactored lottery controller.´
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
feature
good first issue
Good for newcomers
greenkeeper
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
refactor
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KevinMidboe
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KevinMidboe/vinlottis#46
No description provided.
Delete Branch "feat/history-page-by-date"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?