Refactor/implement new design for Wine #48

2020-10-11T16:12:18Z

KevinMidboe commented

2020-10-11 16:12:18 +00:00

(Migrated from github.com)

New design, gutted old code and added intersectionObserver for lazy loading of image.

All wines endpoint returns newest first.
Updated wine w/ new design, removed lots of code.
- Updated wine component to reflect changes in design.
- Removed all methods, computed and unnecessary props.
- The inlineSlot props has been removed, now slot always renders inline.
- Removed functions for custom logic, not this is resides in the parent and should be passed down in the slot.
Reflecting changes no longer use props in Wine.vue.
- Reflecting changes now that wine should not have custom logic. No longer send prop values other than wine down.
- WinnerPage function called from the slot passed down, not using custom :winner prop and @chosenWine event.
Removed unused css.
Implements intersectObserver to lazy load images.
- IntersectionObserver for delaying the load of images until the component
  enteres the viewport.
All wines simplified. Refactor script and template.
Added missing space before rating.
Make sure date is date in dateString().

New design, gutted old code and added intersectionObserver for lazy loading of image. - All wines endpoint returns newest first. - Updated wine w/ new design, removed lots of code. - Updated wine component to reflect changes in design. - Removed all methods, computed and unnecessary props. - The inlineSlot props has been removed, now slot always renders inline. - Removed functions for custom logic, not this is resides in the parent and should be passed down in the slot. - Reflecting changes no longer use props in Wine.vue. - Reflecting changes now that wine should not have custom logic. No longer send prop values other than wine down. - WinnerPage function called from the slot passed down, not using custom :winner prop and @chosenWine event. - Removed unused css. - Implements intersectObserver to lazy load images. - IntersectionObserver for delaying the load of images until the component enteres the viewport. - All wines simplified. Refactor script and template. - Added missing space before rating. - Make sure date is date in dateString().

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KevinMidboe/vinlottis#48