KevinMidboe/vinlottis
1
0
Fork 0
Code Issues 8 Pull Requests 14 Packages Projects Releases Wiki Activity

WIP Refactor - Requested wines ui #53

Merged
KevinMidboe merged 20 commits from refactor/requested-wines-ui into master 2020-11-02 14:20:21 +00:00
Conversation 0 Commits 20 Files Changed 21 +466 -169
KevinMidboe commented 2020-10-11 22:12:01 +00:00 (Migrated from github.com)
Copy Link

Started updating requestedWines to new design.
Added named slots to Wine.vue for higher customization. Here we use slot top and bottom to set request count and request button respectively. Default prop takes delete button if admin, like previous behaviour.

TODO:

  • Add new icon for request count and button
  • Fill icon color when active.
  • Session cookie for what client has requested?

Desktop:
Screenshot 2020-10-12 at 00 14 56

Mobile:
Screenshot 2020-10-12 at 00 15 23

Started updating requestedWines to new design. Added named slots to Wine.vue for higher customization. Here we use slot `top` and `bottom` to set request count and request button respectively. Default prop takes delete button if admin, like previous behaviour. TODO: - [x] Add new icon for request count and button - [x] Fill icon color when active. - [ ] Session cookie for what client has requested? Desktop: ![Screenshot 2020-10-12 at 00 14 56](https://user-images.githubusercontent.com/2287769/95691561-343f9100-0c20-11eb-981e-a76021fa04eb.png) Mobile: ![Screenshot 2020-10-12 at 00 15 23](https://user-images.githubusercontent.com/2287769/95691541-0fe3b480-0c20-11eb-91cd-77107aaf5007.png)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
feature
good first issue
Good for newcomers
greenkeeper
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
refactor
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KevinMidboe
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KevinMidboe/vinlottis#53
No description provided.
Delete Branch "refactor/requested-wines-ui"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?