KevinMidboe/vinlottis
1
0
Fork 0
Code Issues 8 Pull Requests 14 Packages Projects Releases Wiki Activity

Vinlottispage UI redesign #56

Merged
Adrianht merged 26 commits from enhancement/vinlottispage-rework into master 2020-11-03 11:41:39 +00:00
Conversation 9 Commits 26 Files Changed 18 +613 -350
Adrianht commented 2020-10-21 10:50:06 +00:00 (Migrated from github.com)
Copy Link

Started on redesigning the startpage according to design sketches.

  • Gridify stuff

  • Add icons

  • Update Highscore component UI

  • Update TotalBought component UI

  • Update Wines component UI

  • Specify what the button and link in top info should do

  • Create footer

Top

Screenshot 2020-10-21 at 12 52 28

Winners

Screenshot 2020-10-21 at 12 52 41

Raffles

Screenshot 2020-10-21 at 12 56 11

Winners

Screenshot 2020-10-21 at 15 47 35

Started on redesigning the startpage according to design sketches. - [x] Gridify stuff - [x] Add icons - [x] Update Highscore component UI - [x] Update TotalBought component UI - [x] Update Wines component UI - [x] Specify what the button and link in top info should do - [x] Create footer ### Top ![Screenshot 2020-10-21 at 12 52 28](https://user-images.githubusercontent.com/22147672/96710793-d9830380-139c-11eb-99d0-f5f0cc00e72a.png) --- ### Winners ![Screenshot 2020-10-21 at 12 52 41](https://user-images.githubusercontent.com/22147672/96710805-dee04e00-139c-11eb-8cae-d3f99838792f.png) --- ### Raffles ![Screenshot 2020-10-21 at 12 56 11](https://user-images.githubusercontent.com/22147672/96710816-e273d500-139c-11eb-9218-c7335a60bda0.png) ---- ### Winners ![Screenshot 2020-10-21 at 15 47 35](https://user-images.githubusercontent.com/22147672/96729010-f9bebc80-13b4-11eb-896d-9b9e06c7b5de.png)
KevinMidboe (Migrated from github.com) reviewed 2020-11-03 08:32:33 +00:00
src/Vinlottis.vue
KevinMidboe (Migrated from github.com) commented 2020-11-03 08:32:33 +00:00
Copy Link

Renamed file to just Footer.

Renamed file to just `Footer`.
KevinMidboe (Migrated from github.com) reviewed 2020-11-03 08:34:26 +00:00
src/components/PersonalHighscorePage.vue
KevinMidboe (Migrated from github.com) commented 2020-11-03 08:34:25 +00:00
Copy Link

Keys don't need to be entire objects. Does this object have a unique property we can use instead?

Keys don't need to be entire objects. Does this object have a unique property we can use instead?
KevinMidboe (Migrated from github.com) reviewed 2020-11-03 08:40:41 +00:00
src/ui/Highscore.vue
KevinMidboe (Migrated from github.com) commented 2020-11-03 08:35:10 +00:00
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
src/ui/Highscore.vue
@@ -57,0 +58,4 @@
.heading {
display: flex;
justify-content: space-between;
align-items: center;
KevinMidboe (Migrated from github.com) commented 2020-11-03 08:36:12 +00:00
Copy Link

Could also update api to take a size 😬

Could also update api to take a `size` 😬
src/ui/TotalBought.vue
KevinMidboe (Migrated from github.com) commented 2020-11-03 08:37:47 +00:00
Copy Link

Ehhm isn't ballot renamed to raffle?

Ehhm isn't `ballot` renamed to `raffle`?
src/ui/TotalBought.vue
KevinMidboe (Migrated from github.com) commented 2020-11-03 08:38:19 +00:00
Copy Link

angrily shaking fist at the trailing comma

*angrily shaking fist at the trailing comma*
KevinMidboe (Migrated from github.com) reviewed 2020-11-03 08:41:05 +00:00
src/ui/TotalBought.vue
KevinMidboe (Migrated from github.com) commented 2020-11-03 08:41:05 +00:00
Copy Link

Goes for all instances of ballot.

Goes for all instances of `ballot`.
Adrianht (Migrated from github.com) reviewed 2020-11-03 09:13:55 +00:00
src/Vinlottis.vue
Adrianht (Migrated from github.com) commented 2020-11-03 09:13:55 +00:00
Copy Link

Fixed

Fixed
Adrianht (Migrated from github.com) reviewed 2020-11-03 09:14:03 +00:00
src/components/PersonalHighscorePage.vue
Adrianht (Migrated from github.com) commented 2020-11-03 09:14:03 +00:00
Copy Link

Fixed

Fixed
Adrianht (Migrated from github.com) reviewed 2020-11-03 09:14:11 +00:00
src/ui/Highscore.vue
Adrianht (Migrated from github.com) commented 2020-11-03 09:14:11 +00:00
Copy Link

Fixed

Fixed
Adrianht (Migrated from github.com) reviewed 2020-11-03 09:14:28 +00:00
src/ui/TotalBought.vue
Adrianht (Migrated from github.com) commented 2020-11-03 09:14:28 +00:00
Copy Link

Fixed

Fixed
Adrianht (Migrated from github.com) reviewed 2020-11-03 09:15:13 +00:00
src/ui/TotalBought.vue
Adrianht (Migrated from github.com) commented 2020-11-03 09:15:13 +00:00
Copy Link

,,,,,,,,
,

,,,,,,,, ,
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
feature
good first issue
Good for newcomers
greenkeeper
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
refactor
wontfix
This will not be worked on
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KevinMidboe
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KevinMidboe/vinlottis#56
No description provided.
Delete Branch "enhancement/vinlottispage-rework"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?