WIP Functionality to request wines for next lottery #24

Merged
Adrianht merged 23 commits from feat/request-wine into master 2020-09-07 14:28:31 +00:00
4 changed files with 31 additions and 3 deletions
Showing only changes of commit dd9edf160e - Show all commits

View File

@@ -9,6 +9,7 @@ mongoose.connect("mongodb://localhost:27017/vinlottis", {
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
const Purchase = require(path.join(__dirname + "/../schemas/Purchase"));
const Wine = require(path.join(__dirname + "/../schemas/Wine"));
const Highscore = require(path.join(__dirname + "/../schemas/Highscore"));
const RequestedWine = require(path.join(__dirname + "/../schemas/RequestedWine"));
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
const PreLotteryWine = require(path.join(
__dirname + "/../schemas/PreLotteryWine"
));
@@ -103,6 +104,13 @@ router.route("/highscore/statistics").get(async (req, res) => {
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
res.json(highscore);
});
router.route("/wines/all-requested-wines").get(async (req, res) => {
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
const allWines = await RequestedWine.find({}).populate("wine");
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
res.json(allWines);
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
});
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
router.route("/wines/statistics").get(async (req, res) => {
const wines = await Wine.find();
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed

View File

View File

@@ -24,6 +24,12 @@ const overallWineStatistics = () => {
return fetch(url.href).then(resp => resp.json());
};
const allRequestedWines = () => {
const url = new URL("/api/wines/all-requested-wines", BASE_URL);
return fetch(url.href).then(resp => resp.json());
};
const chartWinsByColor = () => {
const url = new URL("/api/purchase/statistics/color", BASE_URL);
@@ -285,6 +291,7 @@ export {
wineSchema,
barcodeToVinmonopolet,
searchForWine,
allRequestedWines,
login,
register,
addAttendee,

View File

@@ -1,14 +1,27 @@
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<template>
<main>
<p>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<h1>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
Alle viner
</p>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
</h1>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<section>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
{{this.wines}}
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
</section>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
</main>
</template>
<script>
export default {
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
import { allRequestedWines } from "@/api";
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
export default {
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
data(){
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
return{
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
wines: undefined
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
},
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
async mounted() {
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
const wines = await allRequestedWines();
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
this.wines = wines
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
</script>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed