WIP Functionality to request wines for next lottery #24

Merged
Adrianht merged 23 commits from feat/request-wine into master 2020-09-07 14:28:31 +00:00
15 changed files with 649 additions and 8 deletions

69
api/request.js Normal file
View File

@@ -0,0 +1,69 @@
const express = require("express");
const path = require("path");
const RequestedWine = require(path.join(
__dirname + "/../schemas/RequestedWine"
));
const Wine = require(path.join(
__dirname + "/../schemas/Wine"
));
const deleteRequestedWineById = async (req, res) => {
const { id } = req.params;
if(id == null){
return res.json({
message: "Id er ikke definert",
success: false
})
}
await RequestedWine.deleteOne({wineId: id})
return res.json({
message: `Slettet vin med id: ${id}`,
success: true
});
}
const getAllRequestedWines = async (req, res) => {
const allWines = await RequestedWine.find({}).populate("wine");
return res.json(allWines);
}
const requestNewWine = async (req, res) => {
const {wine} = req.body
let thisWineIsLOKO = await Wine.findOne({id: wine.id})
if(thisWineIsLOKO == undefined){
thisWineIsLOKO = new Wine({
name: wine.name,
vivinoLink: wine.vivinoLink,
rating: null,
occurences: null,
image: wine.image,
id: wine.id
});
await thisWineIsLOKO.save()
}
let requestedWine = await RequestedWine.findOne({ "wineId": wine.id})
if(requestedWine == undefined){
requestedWine = new RequestedWine({
count: 1,
wineId: wine.id,
wine: thisWineIsLOKO
})
} else {
requestedWine.count += 1;
}
await requestedWine.save()
return res.send(requestedWine);
}
module.exports = {
requestNewWine,
getAllRequestedWines,
deleteRequestedWineById
};

View File

@@ -1,6 +1,4 @@
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
const express = require("express");
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
const path = require("path");
const router = express.Router();
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
const mongoose = require("mongoose");
mongoose.connect("mongodb://localhost:27017/vinlottis", {
useNewUrlParser: true
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:10 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
KevinMidboe commented 2020-09-07 14:00:13 +00:00 (Migrated from github.com)
Review

Remove

Remove
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:49 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:52 +00:00 (Migrated from github.com)
Review

fixed

fixed

View File

@@ -3,9 +3,11 @@ const path = require("path");
// Middleware
const mustBeAuthenticated = require(__dirname + "/../middleware/mustBeAuthenticated");
const setAdminHeaderIfAuthenticated = require(__dirname + "/../middleware/setAdminHeaderIfAuthenticated");
const update = require(path.join(__dirname + "/update"));
const retrieve = require(path.join(__dirname + "/retrieve"));
const request = require(path.join(__dirname + "/request"));
const subscriptionApi = require(path.join(__dirname + "/subscriptions"));
const loginApi = require(path.join(__dirname + "/login"));
const wineinfo = require(path.join(__dirname + "/wineinfo"));
@@ -18,6 +20,12 @@ const lottery = require(path.join(__dirname + "/lottery"));
const router = express.Router();
router.get("/wineinfo/search", wineinfo.wineSearch);
router.get("/request/all", setAdminHeaderIfAuthenticated, request.getAllRequestedWines);
router.post("/request/new-wine", request.requestNewWine);
router.delete("/request/:id", request.deleteRequestedWineById);
router.get("/wineinfo/schema", mustBeAuthenticated, update.schema);
router.get("/wineinfo/:ean", wineinfo.byEAN);

View File

@@ -1,5 +1,51 @@
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
const fetch = require('node-fetch')
KevinMidboe commented 2020-09-04 10:37:03 +00:00 (Migrated from github.com)
Review

Change to 500x500

Change to 500x500
KevinMidboe commented 2020-09-07 08:25:16 +00:00 (Migrated from github.com)
Review

Refactor this document to reflect changes to backend route setup.

TODO:

  • Define this endpoint in /api/router.js (e.g. /wineinfo/search).
  • Change this to be a named anonymous function.
  • Export this function at bottom of doc. (e.g. `module.exports = { NAME_OF_FUNCTION, NAME_OF_FUNCTION_2, ... }
Refactor this document to reflect changes to backend route setup. TODO: - Define this endpoint in `/api/router.js` (e.g. `/wineinfo/search`). - Change this to be a named anonymous function. - Export this function at bottom of doc. (e.g. `module.exports = { NAME_OF_FUNCTION, NAME_OF_FUNCTION_2, ... }
const path = require('path')
const config = require(path.join(__dirname + "/../config/env/lottery.config"));
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
const convertToOurWineObject = wine => {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
if(wine.basic.ageLimit === "18"){
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
return {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
name: wine.basic.productShortName,
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
vivinoLink: "https://www.vinmonopolet.no/p/" + wine.basic.productId,
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
rating: wine.basic.alcoholContent,
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
occurences: 0,
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
id: wine.basic.productId,
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
image: `https://bilder.vinmonopolet.no/cache/500x500-0/${wine.basic.productId}-1.jpg`,
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
price: wine.prices[0].salesPrice.toString(),
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
country: wine.origins.origin.country
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
const wineSearch = async (req, res) => {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
const {query} = req.query
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
let url = new URL(`https://apis.vinmonopolet.no/products/v0/details-normal?productShortNameContains=test&maxResults=15`)
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
url.searchParams.set('productShortNameContains', query)
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
const vinmonopoletResponse = await fetch(url, {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
headers: {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
"Ocp-Apim-Subscription-Key": config.vinmonopoletToken
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
})
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
.then(resp => resp.json())
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
.catch(err => console.error(err))
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
if (vinmonopoletResponse.errors != null) {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
return vinmonopoletResponse.errors.map(error => {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
if (error.type == "UnknownProductError") {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
return res.status(404).json({
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
message: error.message
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
})
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
} else {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
return next()
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
})
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
const winesConverted = vinmonopoletResponse.map(convertToOurWineObject).filter(Boolean)
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
return res.send(winesConverted);
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
const byEAN = async (req, res) => {
const vinmonopoletResponse = await fetch("https://app.vinmonopolet.no/vmpws/v2/vmp/products/barCodeSearch/" + req.params.ean)
@@ -21,5 +67,6 @@ const byEAN = async (req, res) => {
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
};
module.exports = {
byEAN
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
byEAN,
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
wineSearch
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
};
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
KevinMidboe commented 2020-09-07 14:00:35 +00:00 (Migrated from github.com)
Review

Is this used?

Is this used?
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:23:56 +00:00 (Migrated from github.com)
Review

fixed

fixed

View File

@@ -6,5 +6,6 @@ module.exports = {
date: 5,
hours: 15,
apiUrl: undefined,
gatewayToken: undefined
};
gatewayToken: undefined,
vinmonopoletToken: undefined
};

View File

@@ -6,7 +6,7 @@
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"start": "node server.js",
"dev": "cross-env NODE_ENV=development webpack-dev-server --progress",
"dev": "cross-env NODE_ENV=development webpack-dev-server",
"build": "cross-env NODE_ENV=production webpack --progress --hide-modules"
},
"author": "",

13
schemas/RequestedWine.js Normal file
View File

@@ -0,0 +1,13 @@
const mongoose = require("mongoose");
const Schema = mongoose.Schema;
const RequestedWine = new Schema({
count: Number,
wineId: String,
wine: {
type: Schema.Types.ObjectId,
ref: "Wine"
}
});
module.exports = mongoose.model("RequestedWine", RequestedWine);

View File

@@ -9,7 +9,6 @@ const User = require(path.join(__dirname + "/schemas/User"));
const apiRouter = require(path.join(__dirname + "/api/router.js"));
KevinMidboe commented 2020-09-07 08:28:15 +00:00 (Migrated from github.com)
Review

Reflect changes from #21 and move this to /api/router.js.

Reflect changes from #21 and move this to `/api/router.js`.
Adrianht commented 2020-09-07 13:55:35 +00:00 (Migrated from github.com)
Review

fixed

fixed
const loginApi = require(path.join(__dirname + "/api/login"));
const virtualApi = require(path.join(__dirname + "/api/virtualLottery"));
const subscriptionApi = require(path.join(__dirname + "/api/subscriptions"));
//This is required for the chat to work

View File

@@ -1,3 +1,5 @@
import fetch from "node-fetch";
const BASE_URL = __APIURL__ || window.location.origin;
const statistics = () => {
@@ -24,6 +26,16 @@ const overallWineStatistics = () => {
return fetch(url.href).then(resp => resp.json());
};
const allRequestedWines = () => {
const url = new URL("/api/request/all", BASE_URL);
return fetch(url.href)
.then(resp => {
const isAdmin = resp.headers.get("Vinlottis-Admin") || false;
return Promise.all([resp.json(), isAdmin]);
});
};
const chartWinsByColor = () => {
const url = new URL("/api/purchase/statistics/color", BASE_URL);
@@ -108,6 +120,21 @@ const winners = () => {
return fetch(url.href).then(resp => resp.json());
};
const deleteRequestedWine = wineToBeDeleted => {
const url = new URL("api/request/"+ wineToBeDeleted._id, BASE_URL);
const options = {
headers: {
"Content-Type": "application/json"
},
method: "DELETE",
body: JSON.stringify(wineToBeDeleted)
};
return fetch(url.href, options).then(resp => resp.json())
}
const deleteWinners = () => {
const url = new URL("/api/virtual/winner/all", BASE_URL);
@@ -140,6 +167,23 @@ const attendees = () => {
return fetch(url.href).then(resp => resp.json());
};
const requestNewWine = (wine) => {
const options = {
body: JSON.stringify({
wine: wine
}),
headers: {
'Accept': 'application/json',
'Content-Type': 'application/json'
},
method: "post"
}
const url = new URL("/api/request/new-wine", BASE_URL)
return fetch(url.href, options).then(resp => resp.json())
}
const logWines = wines => {
const url = new URL("/api/log/wines", BASE_URL);
@@ -174,6 +218,21 @@ const barcodeToVinmonopolet = id => {
});
};
const searchForWine = searchString => {
const url = new URL("/api/wineinfo/search?query=" + searchString, BASE_URL);
return fetch(url.href).then(async resp => {
if (!resp.ok) {
if (resp.status == 404) {
throw await resp.json();
}
} else {
return resp.json();
}
});
};
const handleErrors = async resp => {
if ([400, 409].includes(resp.status)) {
throw await resp.json();
@@ -287,6 +346,9 @@ export {
logWines,
wineSchema,
barcodeToVinmonopolet,
searchForWine,
requestNewWine,
allRequestedWines,
login,
register,
addAttendee,
@@ -297,6 +359,7 @@ export {
winnersSecure,
deleteWinners,
deleteAttendees,
deleteRequestedWine,
getChatHistory,
finishedDraw,
getAmIWinner,

View File

@@ -0,0 +1,52 @@
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<template>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<main>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<h1>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
Alle foreslåtte viner
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
</h1>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<section class="requested-wines-container">
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<p v-if="wines == undefined || wines.length == 0">Ingen har foreslått noe enda!</p>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<RequestedWineCard v-for="requestedEl in wines" :key="requestedEl.id" :requestedElement="requestedEl" @wineDeleted="filterOutDeletedWine" :showDeleteButton="isAdmin"/>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
</section>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
</main>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
</template>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<script>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
import { allRequestedWines } from "@/api";
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
import RequestedWineCard from "@/ui/RequestedWineCard";
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
export default {
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
components: {
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
RequestedWineCard
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
},
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
data(){
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
return{
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
wines: undefined,
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
canRequest: true,
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
isAdmin: false
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
},
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
methods: {
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
filterOutDeletedWine(wine){
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
this.wines = this.wines.filter(item => item.wine._id !== wine._id)
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
},
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
async refreshData(){
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
[this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
},
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
mounted() {
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
this.refreshData()
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
</script>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
<style lang="scss" scoped>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
h1{
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
text-align: center;
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
.requested-wines-container{
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
display: flex;
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
justify-content: space-around;
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
flex-flow: row wrap;
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
align-items: stretch
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
}
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed
</style>
KevinMidboe commented 2020-09-07 08:29:47 +00:00 (Migrated from github.com)
Review

This is in the template which is scoped to this so we can write: wines == undefined. Also the length of a list will not be less that zero so change check to be wines.length == 0.

This is in the template which is scoped to `this` so we can write: `wines == undefined`. Also the length of a list will not be less that zero so change check to be `wines.length == 0`.
KevinMidboe commented 2020-09-07 08:31:38 +00:00 (Migrated from github.com)
Review

Shorthand would be this.wines = await allRequestedWines() || [];

Shorthand would be `this.wines = await allRequestedWines() || [];`
KevinMidboe commented 2020-09-07 08:33:01 +00:00 (Migrated from github.com)
Review

Could the item deleted be sent up here and we filter it away instead of making a new request?

Could the item deleted be sent up here and we filter it away instead of making a new request?
Adrianht commented 2020-09-07 13:55:41 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:47 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:52 +00:00 (Migrated from github.com)
Review

fixed

fixed
KevinMidboe commented 2020-09-07 14:01:34 +00:00 (Migrated from github.com)
Review
      [this.wines, this.isAdmin] = await allRequestedWines() || [[], false]
```suggestion [this.wines, this.isAdmin] = await allRequestedWines() || [[], false] ```
Adrianht commented 2020-09-07 14:24:02 +00:00 (Migrated from github.com)
Review

fixed

fixed

View File

@@ -0,0 +1,195 @@
<template>
<main>
<h1>
Foreslå en vin!
</h1>
<Modal
v-if="showModal"
modalText="Ønsket ditt har blitt lagt til"
:buttons="modalButtons"
@click="emitFromModalButton"
></Modal>
<section>
<section class="search-section">
<input type="text" v-model="searchString" @keyup.enter="fetchWineFromVin()" placeholder="Søk etter en vin du liker her!🍷">
<button :disabled="!searchString" @click="fetchWineFromVin()" class="vin-button">Søk</button>
</section>
<section v-for="(wine, index) in this.wines" :key="index" class="search-results-container">
<img
v-if="wine.image"
:src="wine.image"
class="wine-image"
:class="{ 'fullscreen': fullscreen }"
/>
<img v-else class="wine-placeholder" alt="Wine image" />
<section class="wine-info">
<h2 v-if="wine.name">{{ wine.name }}</h2>
<h2 v-else>(no name)</h2>
<div class="__details">
<span v-if="wine.rating">{{ wine.rating }}%</span>
<span v-if="wine.price">{{ wine.price }} NOK</span>
<span v-if="wine.country">{{ wine.country }}</span>
</div>
</section>
<section class="buttons">
<button class="vin-button" @click="request(wine)">Foreslå denne</button>
<a
v-if="wine.vivinoLink"
:href="wine.vivinoLink"
class="wine-link"
>Les mer polet</a>
</section>
</section>
<p v-if="this.wines && this.wines.length == 0">
Fant ingen viner med det navnet!
</p>
</section>
</main>
</template>
<script>
import { searchForWine, requestNewWine } from "@/api";
import Wine from "@/ui/Wine";
import Modal from "@/ui/Modal";
export default {
components: {
Wine,
Modal
},
data() {
return {
searchString: undefined,
wines: undefined,
showModal: false,
modalButtons: [
{
text: "Legg til flere viner",
action: "stay"
},
{
text: "Se alle viner",
action: "move"
}
]
}
},
methods: {
fetchWineFromVin(){
if(this.searchString){
this.wines = []
let localSearchString = this.searchString.replace(/ /g,"_");
searchForWine(localSearchString)
.then(res => this.wines = res)
}
},
request(wine){
requestNewWine(wine)
.then(() => this.showModal = true)
},
emitFromModalButton(action){
if(action == "stay"){
this.showModal = false
} else {
this.$router.push("/requested-wines");
}
}
},
}
</script>
<style lang="scss" scoped>
@import "./src/styles/media-queries";
@import "./src/styles/global";
@import "./src/styles/variables";
main{
margin: auto;
width: 80%;
text-align: center;
z-index: 0;
}
input[type="text"] {
width: 100%;
color: black;
border-radius: 4px;
padding: 0.5rem 1rem;
border: 1px solid black;
max-width: 80%;
}
.search-section{
display: flex;
justify-content: space-around;
flex-flow: row;
}
.search-results-container{
display: flex;
padding: 3px;
border-radius: 1px;
box-shadow: 0px 0px 0px 1px rgba(0,0,0,0.3);
margin: 1rem 0;
justify-content: space-around;
flex-flow: row wrap;
align-items: stretch;
.wine-image {
height: 100px;
}
.wine-placeholder {
height: 100px;
width: 70px;
}
.wine-info{
display: flex;
flex-direction: column;
.__details{
display: flex;
flex-direction: column;
}
}
.wine-link {
color: #333333;
font-family: Arial;
text-decoration: none;
font-weight: bold;
border-bottom: 1px solid #ff5fff;
width: fit-content;
}
.buttons{
display: flex;
align-items: center;
order: 2;
justify-content: space-between;
width: 40%;
margin-right: 1rem;
}
@include mobile {
display: flex;
flex-direction: column;
.wine-image {
height: 100px;
width: 50px;
align-self: center;
}
.buttons{
display: flex;
flex-direction: column;
align-self: center;
margin: 1em;
.wine-link{
margin-top: 1em;
}
}
}
}
</style>

View File

@@ -12,6 +12,9 @@ import WinnerPage from "@/components/WinnerPage";
import LotteryPage from "@/components/LotteryPage";
import HistoryPage from "@/components/HistoryPage";
import RequestWine from "@/components/RequestWine";
import AllRequestedWines from "@/components/AllRequestedWines";
const routes = [
{
path: "*",
@@ -52,6 +55,14 @@ const routes = [
{
path: "/history",
component: HistoryPage
},
{
path: "/request",
component: RequestWine
},
{
path: "/requested-wines",
component: AllRequestedWines
}
];

View File

@@ -144,13 +144,17 @@ textarea {
0 16px 32px rgba(0, 0, 0, 0.07), 0 32px 64px rgba(0, 0, 0, 0.07);
}
&:hover {
&:hover:not(:disabled) {
transform: scale(1.02) translateZ(0);
&::after {
opacity: 1;
}
}
&:disabled{
opacity: 0.25;
cursor: not-allowed;
}
}
.no-margin {

101
src/ui/Modal.vue Normal file
View File

@@ -0,0 +1,101 @@
<template>
<transition name="modal-fade">
<main class="modal-backdrop">
<section class="modal">
<header class="modal-header" v-if="headerText">
{{headerText}}
</header>
<section class="modal-body">
<p>
{{modalText}}
</p>
<section class="button-container">
<button v-for="(button, index) in buttons" :key="index" @click="modalButtonClicked(button.action)" class="vin-button">
{{button.text}}
</button>
</section>
</section>
</section>
</main>
</transition>
</template>
<script>
export default {
props: {
headerText: {
type: String,
required: false
},
modalText: {
type: String,
required: true
},
buttons: {
type: Array,
required: true
},
},
methods:{
modalButtonClicked(action){
this.$emit('click', action)
}
}
}
</script>
<style lang="scss" scoped>
@import "../styles/global.scss";
.modal-fade-enter,
.modal-fade-leave-active {
opacity: 0;
}
.modal-fade-enter-active,
.modal-fade-leave-active {
transition: opacity .5s ease
}
.modal-backdrop {
position: fixed;
top: 0;
bottom: 0;
left: 0;
right: 0;
background-color: rgba(0, 0, 0, 0.3);
display: flex;
justify-content: center;
align-items: center;
z-index: 1;
width: 100vw;
height: 100vh;
}
.modal {
background: #FFFFFF;
-webkit-box-shadow: 0px 0px 22px 1px rgba(0, 0, 0, 0.65);
-moz-box-shadow: 0px 0px 22px 1px rgba(0, 0, 0, 0.65);
box-shadow: 0px 0px 22px 1px rgba(0, 0, 0, 0.65);
overflow-x: auto;
display: flex;
flex-direction: column;
}
.modal-header {
padding: 15px;
display: flex;
}
.modal-header {
border-bottom: 1px solid #eeeeee;
color: #4AAE9B;
justify-content: space-between;
}
.modal-body {
position: relative;
padding: 20px 10px;
}
</style>

View File

@@ -0,0 +1,80 @@
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<template>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<div class="requested-wine">
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<img
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
v-if="wine.image"
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
:src="wine.image"
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
class="wine-image"
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
:class="{ 'fullscreen': fullscreen }"
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
/>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<img v-else class="wine-placeholder" alt="Wine image" />
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<section class="wine-info">
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<h3 v-if="wine.name">{{ wine.name }}</h3>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<h3 v-else>(no name)</h3>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<p>Antall ganger denne har blitt foreslått: {{requestedElement.count}}</p>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<section class="buttons">
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<button class="vin-button" @click="request(wine)" v-if="!locallyRequested">Foreslå denne</button>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<a
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
v-if="wine.vivinoLink"
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
:href="wine.vivinoLink"
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
class="wine-link"
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
>Les mer polet</a>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
</section>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<button @click="deleteWine(wine)" v-if="showDeleteButton == true">
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
Slett vinen
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
</button>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
</section>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
</div>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
</template>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<script>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
import { deleteRequestedWine, requestNewWine } from "@/api";
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
export default {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
data(){
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
return {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
wine: this.requestedElement.wine,
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
locallyRequested: false
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
}
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
},
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
props: {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
requestedElement: {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
required: true,
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
type: Object
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
},
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
showDeleteButton: {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
required: false,
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
type: Boolean,
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
default: false
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
}
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
},
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
methods: {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
request(wine){
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
this.locallyRequested = true
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
this.requestedElement.count = this.requestedElement.count +1
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
requestNewWine(wine)
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
},
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
async deleteWine(wine) {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
if (window.confirm("Er du sikker på at du vil slette vinen?")) {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
let response = await deleteRequestedWine(wine);
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
if (response['success'] == true) {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
this.$emit('wineDeleted', wine);
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
} else {
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
alert("Klarte ikke slette vinen");
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
}
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
}
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
},
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
},
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
}
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
</script>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
<style lang="scss" scoped>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
.requested-wine{
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
padding: 20px;
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
border-radius: 1px;
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
margin: 1rem 0;
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
-webkit-box-shadow: 0px 0px 10px 1px rgba(0, 0, 0, 0.65);
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
-moz-box-shadow: 0px 0px 10px 1px rgba(0, 0, 0, 0.65);
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
box-shadow: 0px 0px 10px 1px rgba(0, 0, 0, 0.65);
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
}
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed
</style>
KevinMidboe commented 2020-09-07 08:34:04 +00:00 (Migrated from github.com)
Review

Rename too wineDeleted and emit the wine element.

Rename too `wineDeleted` and emit the wine element.
KevinMidboe commented 2020-09-07 08:35:18 +00:00 (Migrated from github.com)
Review

Vinnere ?

Vinnere ?
Adrianht commented 2020-09-07 13:55:58 +00:00 (Migrated from github.com)
Review

fixed

fixed
Adrianht commented 2020-09-07 13:56:06 +00:00 (Migrated from github.com)
Review

🤷‍♂️ fixed

🤷‍♂️ fixed