KevinMidboe/vinlottis
1
0
Fork 0
Code Issues 8 Pull Requests 14 Packages Projects Releases Wiki Activity

Rework the banner #34

Merged
Adrianht merged 7 commits from enhancement/header-rework into master 2020-09-09 07:54:42 +00:00
Conversation 8 Commits 7 Files Changed 11 +5 -10
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 13e0c26eef - Show all commits

15
src/ui/Banner.vue
View File

@@ -5,15 +5,15 @@
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
<img src="/public/assets/images/knowit.svg" alt="knowit logo" />
</router-link>
<a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="menuHeight">
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
<a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="{'open': isOpen, 'collapsed': !isOpen}" >
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
<span class="menu-toggle"></span>
<span class="menu-toggle"></span>
<span class="menu-toggle"></span>
</a>
<nav class="menu" :class="menuHeight">
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
<nav class="menu" :class="{'open': isOpen, 'collapsed': !isOpen}">
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
<router-link v-for="(route, index) in routes" :key="index" :to="route.route" class="menu-item-link" >
<a @click="toggleMenu" class="single-route" :class="menuHeight">{{route.name}}</a>
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
<a @click="toggleMenu" class="single-route" :class="{'open': isOpen, 'collapsed': !isOpen}">{{route.name}}</a>
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
</router-link>
</nav>
@@ -33,7 +33,7 @@
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
export default {
data() {
return {
menuHeight: 'collapsed',
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
isOpen: false,
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
nextLottery: null,
days: 0,
hours: 0,
@@ -68,12 +68,7 @@ export default {
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
},
methods: {
toggleMenu(){
console.log(this.menuHeight)
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
if(this.menuHeight === 'collapsed'){
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
this.menuHeight = 'open'
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
} else {
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
this.menuHeight = 'collapsed'
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
}
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
this.isOpen = this.isOpen ? false : true;
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
},
pad: function(num) {
if (num < 10) {
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
KevinMidboe commented 2020-09-08 15:02:08 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="{ 'desktop-only': isOpen }">
```suggestion <nav class="menu" :class="{ 'desktop-only': isOpen }"> ```
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:21:37 +00:00 (Migrated from github.com)
Review
Copy Link

fixed

fixed
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:29:26 +00:00 (Migrated from github.com)
Review
Copy Link
    <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <a class="menu-toggle-container" aria-label="show-menu" @click="toggleMenu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:22 +00:00 (Migrated from github.com)
Review
Copy Link
    <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" >
```suggestion <nav class="menu" :class="isOpen ? 'open' : 'collapsed'" > ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```
Adrianht commented 2020-09-09 07:30:39 +00:00 (Migrated from github.com)
Review
Copy Link
        <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a>
```suggestion <a @click="toggleMenu" class="single-route" :class="isOpen ? 'open' : 'collapsed'">{{route.name}}</a> ```