KevinMidboe/vinlottis
1
0
Fork 0
Code Issues 8 Pull Requests 14 Packages Projects Releases Wiki Activity

Vinlottispage UI redesign #56

Merged
Adrianht merged 26 commits from enhancement/vinlottispage-rework into master 2020-11-03 11:41:39 +00:00
Conversation 9 Commits 26 Files Changed 18 +4 -9
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 397c635551 - Show all commits

13
src/ui/Highscore.vue
View File

@@ -68,19 +68,14 @@ ol {
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
}
.winner-list-container {
width: 100%;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
display: flex;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
justify-content: space-evenly;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
flex-wrap: wrap;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
column-gap: 1em;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
row-gap: 1em;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
margin: 0;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
// align-items: baseline;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
display: grid;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
grid-template-columns: repeat(auto-fill, minmax(12.5em, 1fr));
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
gap: 5%;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
.single-winner {
width: 12.5em;
background: $primary;
padding: 1em;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
padding: 1em 0 0 1em;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
display: grid;
grid-template: 1fr .3fr / 1fr 1fr 1fr;
align-items: center;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review
Copy Link

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review
Copy Link

Fixed

Fixed