Vinlottispage UI redesign #56

Merged
Adrianht merged 26 commits from enhancement/vinlottispage-rework into master 2020-11-03 11:41:39 +00:00
Showing only changes of commit 8758752b26 - Show all commits

View File

@@ -29,15 +29,8 @@ export default {
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
},
async mounted() {
let response = await highscoreStatistics();
response.sort((a, b) => {
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
return a.wins.length > b.wins.length ? -1 : 1;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
});
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
response = response.filter(
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
person => person.name != null && person.name != ""
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
);
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
this.highscore = response.slice(0, 5);
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
// response.sort((a, b) => a.wins.length < b.wins.length ? 1 : -1)
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
// this.highscore = this.generateScoreBoard(response.slice(0, 10));
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
response.sort((a, b) => a.wins.length < b.wins.length ? 1 : -1)
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
this.highscore = this.generateScoreBoard(response.slice(0, 5));
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
},
methods: {
generateScoreBoard(highscore=this.highscore) {
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed