Vinlottispage UI redesign #56

Merged
Adrianht merged 26 commits from enhancement/vinlottispage-rework into master 2020-11-03 11:41:39 +00:00
3 changed files with 40 additions and 7 deletions
Showing only changes of commit 9f2adb54e0 - Show all commits

View File

@@ -2,6 +2,7 @@
<div class="app-container"> <div class="app-container">
<banner :routes="routes"/> <banner :routes="routes"/>
<router-view /> <router-view />
<WineFooter />
<UpdateToast <UpdateToast
v-if="showToast" v-if="showToast"
:text="toastText" :text="toastText"
@@ -14,11 +15,12 @@
<script> <script>
import ServiceWorkerMixin from "@/mixins/ServiceWorkerMixin"; import ServiceWorkerMixin from "@/mixins/ServiceWorkerMixin";
import banner from "@/ui/Banner"; import banner from "@/ui/Banner";
import WineFooter from "@/ui/WineFooter";
import UpdateToast from "@/ui/UpdateToast"; import UpdateToast from "@/ui/UpdateToast";
export default { export default {
name: "vinlottis", name: "vinlottis",
components: { banner, UpdateToast }, components: { banner, UpdateToast, WineFooter },
props: {}, props: {},
data() { data() {
return { return {

View File

@@ -61,7 +61,6 @@ export default {
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
</script> </script>
KevinMidboe commented 2020-11-03 08:36:12 +00:00 (Migrated from github.com)
Review

Could also update api to take a size 😬

Could also update api to take a `size` 😬
<style lang="scss" scoped> <style lang="scss" scoped>
@import "../styles/media-queries.scss";
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
@import "../styles/variables.scss"; @import "../styles/variables.scss";
.heading { .heading {
display: flex; display: flex;
@@ -93,29 +92,29 @@ ol {
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
gap: 5%; gap: 5%;
.single-winner { .single-winner {
box-sizing: border-box;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
width: 100%; width: 100%;
background: $primary; background: $primary;
display: grid; display: grid;
grid-template: 1fr .3fr / 1fr 1fr 1fr; grid-template-columns: 1fr 1fr 1fr;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
align-items: center; align-items: center;
padding: 1em;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
i { i {
font-size: 3em; font-size: 3em;
width: max-content;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
justify-self: end;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
} }
.placement { .placement {
grid-row: 1; grid-row: 1;
grid-column: 1 / 3; grid-column: 1 / 3;
font-size: 3em; font-size: 3em;
margin-left: 5px;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
padding: .2em 0 0 5px;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
} }
.winner-name { .winner-name {
grid-row: 2; grid-row: 2;
grid-column: 1 / -1; grid-column: 1 / -1;
margin-left: 5px;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
padding-left: 5px;
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
} }
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
KevinMidboe commented 2020-11-03 08:35:10 +00:00 (Migrated from github.com)
Review

Same as above. Try not to use entire objects as keys.

Same as above. Try not to use entire objects as keys.
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed
Adrianht commented 2020-11-03 09:14:11 +00:00 (Migrated from github.com)
Review

Fixed

Fixed

32
src/ui/WineFooter.vue Normal file
View File

@@ -0,0 +1,32 @@
<template>
<footer>
<router-link to="/" class="company-logo">
<img src="/public/assets/images/knowit.svg" alt="knowit logo">
</router-link>
</footer>
</template>
<script>
export default {
name: 'WineFooter'
}
</script>
<style lang="scss" scoped>
footer {
width: 100%;
height: 100px;
display: flex;
justify-content: flex-end;
align-items: center;
background: #f4f4f4;
.company-logo{
padding: 0 5em 0 0;
img{
width: 100px;
}
}
}
</style>