From ecd4e2b470ea01474de7083a4f8080348808d55e Mon Sep 17 00:00:00 2001 From: jjyyxx <1449843302@qq.com> Date: Thu, 1 Feb 2018 11:03:10 +0800 Subject: [PATCH 1/2] Fix a bug with toggle method When calling hide on invisible modal with scroll set to true (though it's meaningless), the v--modal-block-scroll class will be added to body and block the UI. --- src/Modal.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Modal.vue b/src/Modal.vue index 43e756e..2bd69ae 100644 --- a/src/Modal.vue +++ b/src/Modal.vue @@ -440,6 +440,7 @@ export default { */ toggle(state, params) { const { reset, scrollable, visible } = this + if (visible === state) return const beforeEventName = visible ? 'before-close' : 'before-open' if (beforeEventName === 'before-open') { From 106f5c9b10a62a7396dbcbd3b3ec3d715a37a546 Mon Sep 17 00:00:00 2001 From: jjyyxx <1449843302@qq.com> Date: Thu, 1 Feb 2018 11:08:53 +0800 Subject: [PATCH 2/2] fix a typo in comment --- src/Modal.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modal.vue b/src/Modal.vue index 2bd69ae..d7692a4 100644 --- a/src/Modal.vue +++ b/src/Modal.vue @@ -434,7 +434,7 @@ export default { this.$emit('resize', resizeEvent) }, /** - * Event handler which is triggered on $modal.show and $modal.hight + * Event handler which is triggered on $modal.show and $modal.hide * BeforeEvents: ('before-close' and 'before-open') are `$emit`ed here, * but AfterEvents ('opened' and 'closed') are moved to `watch.visible`. */