From e3179625d0b3d023ef278015648a8e7e1512adf3 Mon Sep 17 00:00:00 2001 From: arve0 Date: Wed, 13 Sep 2017 20:24:33 +0200 Subject: [PATCH] Remove Vue runtime dependency This allow the bundle to be used in jsfiddle, plnkr, jsbin, etc., as the bundle does not depend on Vue. The problem lies on second line of bundle ```js "object" == typeof exports ? exports["vue-js-modal"] = factory(require("vue")) : root["vue-js-modal"] = factory(root.vue) ``` where `factory` tries to find `root.vue`, but the official Vue bundle exports as `root.Vue`. Removing the runtime dependency solves this. `Object.assign` is available in all browsers but IE: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign --- build/webpack.base.config.js | 8 -------- src/Modal.vue | 3 +-- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/build/webpack.base.config.js b/build/webpack.base.config.js index beec90a..80a03f1 100644 --- a/build/webpack.base.config.js +++ b/build/webpack.base.config.js @@ -25,14 +25,6 @@ module.exports = { } ] }, - externals: { - vue: 'vue' - }, - resolve: { - alias: { - 'vue$': 'vue/dist/vue.esm.js' - } - }, devtool: '#source-map', plugins: [ new UglifyJSPlugin({ diff --git a/src/Modal.vue b/src/Modal.vue index 6ae2a89..46a482a 100644 --- a/src/Modal.vue +++ b/src/Modal.vue @@ -28,7 +28,6 @@