KevinMidboe/vue-js-modal
1
0
Fork 0
mirror of https://github.com/KevinMidboe/vue-js-modal.git synced 2025-10-29 18:00:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor code cleaning

Browse Source
This commit is contained in:
euvl
2017-10-09 14:23:21 +01:00
parent 220573f137
commit 4652eb0b86
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
demo/client_side_rendering/src/components/SizeModal.vue
View File

@@ -17,7 +17,11 @@
<div class="size-modal-content"> <div class="size-modal-content">
<div>A new paragraph will be added every 5 sec to show how <b>height</b> scales.</div> <div>A new paragraph will be added every 5 sec to show how <b>height</b> scales.</div>
<div v-for="(p, i) in paragraphs" :key="i"> <div v-for="(p, i) in paragraphs" :key="i">
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla dictum purus egestas libero ornare venenatis. Maecenas pharetra tortor eu tortor imperdiet, a faucibus quam finibus. Nulla id lacinia quam. Praesent imperdiet sed magna non finibus. Aenean blandit, mauris vitae lacinia rutrum, nunc mi scelerisque sem, in laoreet sem lectus ut orci. Ut egestas nulla in vehicula feugiat. Vivamus tincidunt nisi vel risus dictum suscipit. Nulla id blandit mi, vulputate aliquam enim. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla dictum purus egestas libero ornare venenatis.
Maecenas pharetra tortor eu tortor imperdiet, a faucibus quam finibus. Nulla id lacinia quam.
Praesent imperdiet sed magna non finibus. Aenean blandit, mauris vitae lacinia rutrum,
nunc mi scelerisque sem, in laoreet sem lectus ut orci. Ut egestas nulla in vehicula feugiat.
Vivamus tincidunt nisi vel risus dictum suscipit. Nulla id blandit mi, vulputate aliquam enim.
</div> </div>
</div> </div>
</modal> </modal>
@@ -47,6 +51,7 @@
opened (e) { opened (e) {
// e.ref should not be undefined here // e.ref should not be undefined here
console.log('opened', e) console.log('opened', e)
console.log('ref', e.ref)
}, },
closed (e) { closed (e) {

10
src/Modal.vue
View File

@@ -381,15 +381,14 @@
* Generates event object * Generates event object
*/ */
genEventObject (params) { genEventObject (params) {
// @todo: clean this up (change to ...) var eventData = {
var data = {
name: this.name, name: this.name,
timestamp: Date.now(), timestamp: Date.now(),
canceled: false, canceled: false,
ref: this.$refs.modal ref: this.$refs.modal
} }
return Object.assign(data, params || {}) return Object.assign(eventData, params || {})
}, },
/** /**
* Event handler which is triggered on modal resize * Event handler which is triggered on modal resize
@@ -421,6 +420,7 @@
if (beforeEventName === 'before-open') { if (beforeEventName === 'before-open') {
if (reset) { if (reset) {
this.setInitialSize() this.setInitialSize()
this.shift.left = 0 this.shift.left = 0
this.shift.top = 0 this.shift.top = 0
} }
@@ -631,8 +631,8 @@
} }
.v--modal-overlay.scrollable .v--modal-box { .v--modal-overlay.scrollable .v--modal-box {
margin-bottom: 10px; margin-bottom: 2px;
transition: top 0.2s ease; /* transition: top 0.2s ease; */
} }
.v--modal { .v--modal {