KevinMidboe/vue-js-modal
1
0
Fork 0
mirror of https://github.com/KevinMidboe/vue-js-modal.git synced 2025-12-29 13:21:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #105 from DaxChen/master

Browse Source 
Fix MutationObserver callback $refs.modal undefined
This commit is contained in:
Yev Vlasenko
2017-10-18 11:07:30 +01:00
committed by GitHub
parent 04337a607b c144f2f4f6
commit 7a2e002df6
4 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
demo/server_side_rendering/package.json
View File

@@ -4,7 +4,7 @@
"start": "nuxt" "start": "nuxt"
}, },
"dependencies": { "dependencies": {
"vue-js-modal": "latest", "nuxt": "^1.0.0-rc3",
"nuxt": "^1.0.0-rc3" "vue-js-modal": "../../"
} }
} }

10
dist/index.js vendored
View File

File diff suppressed because one or more lines are too long

10
dist/ssr.index.js vendored
View File

File diff suppressed because one or more lines are too long

11
src/Modal.vue
View File

@@ -560,11 +560,6 @@
const afterEvent = this.genEventObject({ state }) const afterEvent = this.genEventObject({ state })
this.$emit(afterEventName, afterEvent) this.$emit(afterEventName, afterEvent)
// recalculate the true modal height
if (state && this.isAutoHeight) {
this.updateRenderedHeight()
}
}, },
/** /**
@@ -574,8 +569,10 @@
* 2. MutationObserver's observe callback * 2. MutationObserver's observe callback
*/ */
updateRenderedHeight () { updateRenderedHeight () {
this.modal.renderedHeight = this.$refs.modal if (this.$refs.modal) {
.getBoundingClientRect().height this.modal.renderedHeight = this.$refs.modal
.getBoundingClientRect().height
}
}, },
/** /**