KevinMidboe/linguist
1
0
Fork 0
mirror of https://github.com/KevinMidboe/linguist.git synced 2025-10-29 17:50:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use question marks in struct fields

Browse Source 
Apparently it doesn't work in Ruby 1.9.
This commit is contained in:
Adam Roben
2014-12-22 17:06:49 -05:00
parent 1634d787ec
commit 33afa30c30
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
script/fast-submodule-update
View File

@@ -12,7 +12,7 @@ SLOW_SUBMODULES = %w[
vendor/grammars/ioke-outdated vendor/grammars/ioke-outdated
] ]
class TaskResult < Struct.new(:submodule, :output, :success?); end class TaskResult < Struct.new(:submodule, :output, :status); end
def run_process(*args) def run_process(*args)
read, write = IO.pipe read, write = IO.pipe
@@ -21,12 +21,12 @@ def run_process(*args)
output = read.read output = read.read
read.close read.close
Process.wait(pid) Process.wait(pid)
[output, $?.success?] [output, $?]
end end
def update_submodule(submodule) def update_submodule(submodule)
output, success = run_process("git", "submodule", "update", "--", submodule) output, status = run_process("git", "submodule", "update", "--", submodule)
TaskResult.new(submodule, output, success) TaskResult.new(submodule, output, status)
end end
def run_thread(submodules, results) def run_thread(submodules, results)
@@ -58,7 +58,7 @@ end
success = true success = true
SUBMODULES.each do SUBMODULES.each do
result = results.pop result = results.pop
unless result.success? unless result.status.success?
success = false success = false
puts "Error updating #{result.submodule}" puts "Error updating #{result.submodule}"
end end